OpenStack Identity (keystone)

Broken host:port splitting

Bug #1988168 reported by Bence Romsics on 2022-08-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Identity (keystone)	Fix Released	Undecided	Bence Romsics

Bug Description

Our users found a bug while POSTing to /v3/ec2tokens. I could simplify the reproduction to this script:

$ cat keystone-post-ec2tokens.sh
#! /bin/sh

# source openrc admin admin
# keystone-post-ec2tokens.sh http://127.0.0.1/identity/v3

keystone_base_url="${1:?}"

cleanup () {
openstack ec2 credential delete "$access"
}
trap cleanup EXIT

#host="localhost"
host="localhost:123"
#host="1.2.3.4:123"
#host="[fc00::]:123"
access="$( openstack ec2 credential create -f value -c access )"
secret="$( openstack ec2 credential show "$access" -f value -c secret )"
signature="intentionally-invalid"

cat <<EOF |
{
    "credentials": {
        "access": "$access",
        "host": "$host",
        "params": {
            "Action": "Test",
            "SignatureMethod": "HmacSHA256",
            "SignatureVersion": "2",
            "Timestamp": "2000-01-01T00:00:00Z"
        },
        "path": "/",
        "secret": "$secret",
        "signature": "$signature",
        "verb": "GET"
    }
}
EOF
curl \
    -s \
    -d @- \
    -H "Content-Type: application/json" \
    -H "Accept: application/json" \
    -X POST \
    "$keystone_base_url/ec2tokens"
END-OF-SCRIPT

Using any of the host values containing a port number, keystone throws an Internal Server Error:

~/keystone-post-ec2tokens.sh http://127.0.0.1/identity/v3
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
<h1>Internal Server Error</h1>
<p>The server encountered an internal error or
misconfiguration and was unable to complete
your request.</p>
<p>Please contact the server administrator at
webmaster@localhost to inform them of the time this error occurred,
and the actions you performed just before this error.</p>
<p>More information about this error may be available
in the server error log.</p>
<hr>
<address>Apache/2.4.52 (Ubuntu) Server at 127.0.0.1 Port 80</address>
</body></html>

With the following stack trace in the logs:

aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone Traceback (most recent call last):
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 2548, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.wsgi_app(environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/werkzeug/middleware/proxy_fix.py", line 187, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.app(environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 129, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = self.call_func(req, *args, **kw)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 193, in call_func
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.func(req, *args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/oslo_middleware/base.py", line 124, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone response = req.get_response(self.application)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1313, in send
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone status, headers, app_iter = self.call_application(
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1278, in call_application
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone app_iter = application(self.environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 143, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return resp(environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 129, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = self.call_func(req, *args, **kw)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 193, in call_func
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.func(req, *args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/oslo_middleware/base.py", line 124, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone response = req.get_response(self.application)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1313, in send
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone status, headers, app_iter = self.call_application(
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1278, in call_application
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone app_iter = application(self.environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 129, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = self.call_func(req, *args, **kw)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 193, in call_func
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.func(req, *args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/osprofiler/web.py", line 111, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return request.get_response(self.application)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1313, in send
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone status, headers, app_iter = self.call_application(
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1278, in call_application
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone app_iter = application(self.environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 129, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = self.call_func(req, *args, **kw)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 193, in call_func
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.func(req, *args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/oslo_middleware/request_id.py", line 58, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone response = req.get_response(self.application)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1313, in send
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone status, headers, app_iter = self.call_application(
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1278, in call_application
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone app_iter = application(self.environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/opt/stack/keystone/keystone/server/flask/request_processing/middleware/url_normalize.py", line 38, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.app(environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 129, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = self.call_func(req, *args, **kw)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/dec.py", line 193, in call_func
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.func(req, *args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/keystonemiddleware/auth_token/__init__.py", line 341, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone response = req.get_response(self._app)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1313, in send
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone status, headers, app_iter = self.call_application(
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/webob/request.py", line 1278, in call_application
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone app_iter = application(self.environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/werkzeug/middleware/dispatcher.py", line 78, in __call__
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return app(environ, start_response)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 2528, in wsgi_app
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone response = self.handle_exception(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 271, in error_router
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return original_handler(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 271, in error_router
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return original_handler(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 271, in error_router
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return original_handler(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone [Previous line repeated 28 more times]
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 2525, in wsgi_app
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone response = self.full_dispatch_request()
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 1822, in full_dispatch_request
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone rv = self.handle_user_exception(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 271, in error_router
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return original_handler(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 271, in error_router
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return original_handler(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 271, in error_router
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return original_handler(e)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone [Previous line repeated 28 more times]
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 1820, in full_dispatch_request
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone rv = self.dispatch_request()
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/app.py", line 1796, in dispatch_request
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 467, in wrapper
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = resource(*args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask/views.py", line 107, in view
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return current_app.ensure_sync(self.dispatch_request)(**kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/usr/local/lib/python3.10/dist-packages/flask_restful/__init__.py", line 582, in dispatch_request
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone resp = meth(*args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/opt/stack/keystone/keystone/server/flask/common.py", line 1064, in wrapper
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone return f(*args, **kwargs)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/opt/stack/keystone/keystone/api/ec2tokens.py", line 67, in post
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone token = self.handle_authenticate()
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/opt/stack/keystone/keystone/api/_shared/EC2_S3_Resource.py", line 122, in handle_authenticate
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone self._check_signature(cred_data, credentials)
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone File "/opt/stack/keystone/keystone/api/ec2tokens.py", line 45, in _check_signature
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone hostname, _port = credentials.split(':')
aug 30 11:53:59 devstack0 <email address hidden>[31882]: ERROR keystone AttributeError: 'dict' object has no attribute 'split'

Keystone raises on this line:

https://opendev.org/openstack/keystone/src/commit/051aca8e8a488efc51817463dab8e4daafbbbf59/keystone/api/ec2tokens.py#L45

Clearly the author wanted to split credentials['host'] and not credentials.

Without the bug present, keystone should reject the request as unauthorized (since the signature is not computed properly).

devstack 90e5479f
keystone 051aca8e8

Posting a proposed fix soon.

By the way: I found the /v2.0 api-ref for /ec2tokens, which marked it as deprecated. Despite this I found the same resources working under /v3, but I could not find anything about them in the /v3 api-ref. Did I miss something?

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-08-30: Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/keystone/+/855198

Changed in keystone:
status:	New → In Progress

Bence Romsics (bence-romsics) on 2022-08-30

Changed in keystone:
assignee:	nobody → Bence Romsics (bence-romsics)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-07: Fix merged to keystone (master)

Reviewed: https://review.opendev.org/c/openstack/keystone/+/855198
Committed: https://opendev.org/openstack/keystone/commit/6c35b366e3c8c6d7f47471b93f5315582301c5ef
Submitter: "Zuul (22348)"
Branch: master

commit 6c35b366e3c8c6d7f47471b93f5315582301c5ef
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.

Change-Id: I1d90dfcea3568e2a9b22069daa428ea6a2a38bd6
Closes-Bug: #1988168

Changed in keystone:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-08: Fix proposed to keystone (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/keystone/+/856489

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-08: Fix proposed to keystone (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/keystone/+/856510

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-08: Fix proposed to keystone (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/keystone/+/856511

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-08: Fix proposed to keystone (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/keystone/+/856512

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-08: Fix proposed to keystone (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/keystone/+/856513

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-08: Fix proposed to keystone (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/keystone/+/856514

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-11: Fix merged to keystone (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/keystone/+/856489
Committed: https://opendev.org/openstack/keystone/commit/d39790ac4e9dc25af09cdddc6217e36bacbc2bb1
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit d39790ac4e9dc25af09cdddc6217e36bacbc2bb1
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.

    Change-Id: I1d90dfcea3568e2a9b22069daa428ea6a2a38bd6
    Closes-Bug: #1988168
    (cherry picked from commit 6c35b366e3c8c6d7f47471b93f5315582301c5ef)

tags:

added: in-stable-yoga

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-14: Fix included in openstack/keystone 22.0.0.0rc1

#10

This issue was fixed in the openstack/keystone 22.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-16: Fix merged to keystone (stable/xena)

#11

Reviewed: https://review.opendev.org/c/openstack/keystone/+/856510
Committed: https://opendev.org/openstack/keystone/commit/0bb9cdee71805af1a7cb0a7db110b336eae5da1e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 0bb9cdee71805af1a7cb0a7db110b336eae5da1e
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.

tags:

added: in-stable-xena

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-09-16: Fix merged to keystone (stable/wallaby)

#12

Reviewed: https://review.opendev.org/c/openstack/keystone/+/856511
Committed: https://opendev.org/openstack/keystone/commit/aa50b963cce20a76db0c4834b3716d3658c784af
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit aa50b963cce20a76db0c4834b3716d3658c784af
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.

tags:

added: in-stable-wallaby

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-10-26: Fix merged to keystone (stable/victoria)

#13

Reviewed: https://review.opendev.org/c/openstack/keystone/+/856512
Committed: https://opendev.org/openstack/keystone/commit/fe837d87c949f6a2347cf79d81b66214f0a449b3
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit fe837d87c949f6a2347cf79d81b66214f0a449b3
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.

    Change-Id: I1d90dfcea3568e2a9b22069daa428ea6a2a38bd6
    Closes-Bug: #1988168
    (cherry picked from commit 6c35b366e3c8c6d7f47471b93f5315582301c5ef)
    (cherry picked from commit d39790ac4e9dc25af09cdddc6217e36bacbc2bb1)
    (cherry picked from commit 0bb9cdee71805af1a7cb0a7db110b336eae5da1e)
    (cherry picked from commit aa50b963cce20a76db0c4834b3716d3658c784af)

tags:

added: in-stable-victoria

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-10-28: Fix merged to keystone (stable/ussuri)

#14

Reviewed: https://review.opendev.org/c/openstack/keystone/+/856513
Committed: https://opendev.org/openstack/keystone/commit/1ab860a08e527ca9e0c82a49fbf004d415fec991
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 1ab860a08e527ca9e0c82a49fbf004d415fec991
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.

tags:

added: in-stable-ussuri

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-11-03: Fix merged to keystone (stable/train)

#15

Reviewed: https://review.opendev.org/c/openstack/keystone/+/856514
Committed: https://opendev.org/openstack/keystone/commit/8d883f011c586f0e79c56f0f70f9455997d70012
Submitter: "Zuul (22348)"
Branch: stable/train

commit 8d883f011c586f0e79c56f0f70f9455997d70012
Author: Bence Romsics <email address hidden>
Date: Mon Aug 29 16:03:44 2022 +0200

Fix host:port handling

    When we check the EC2 signature without the port part of the host value
    received, we should properly split host:port. Keep in mind the splitting
    should work for values like [fc00::]:123 too.