choose among target xfer faultly propose same sign transaction

[Chris Uglow]

Having imported transactions from a csv file for a couple of accounts e.g. current & savings I want to link internal transfers between these to remove them from income/expenses reports. This is possible by selecting one of the transactions (from the account window) and changing it to a transfer (in the transaction dialogue), selecting the other account, then selecting the matching transaction in that account (after pressing OK in the transaction dialogue). However, if I have an outgoing transfer (i.e. an expense) and accidentally click "income" first (in the transaction dialogue) the sign changes, then I click "transfer" but the sign remains in this incorrect state in the transfer. When selecting the matching transaction in the other account there is no validation to ensure the signs are opposite so I can create a transfer that either creates or destroys money despite the transactions being linked.

Suggested fix:
1. Ensure transfers are always consistent
2. Warn the user if the selected matching transaction in a transfer is of the same sign
3. Prompt the user with a dialogue when changing the sign of a transaction (perhaps this should be a configurable option)

HomeBank version:
v 5.5.6
Running against GTK+ 3.24.33

OS: Windows 10 Home 21H2

[Maxime DOYEN (mdoyen)]

the problem was just that the suggesting was comparing amount in ABS (I don't remember nor understand why I did this)
=> I changed to elect suggested txn with comparing src amnt = -dst amnt
so now the txn suggested are always apposite sign