Double right-clicking cue point in upper waveform crashes Mixxx entirely

[Marcel Schwettmann]

Whenever wanting to edit an cue point via the waveform I sometimes happen to make a double-click by mistake and this causes the software to freeze and then crash making me lose all my cue point progress *sadface*

Guess I will have to edit the cue points via the waveform overview as this bug does not occurr there, but I am still hoping that someone could fix it at some point :)

Hardware information:
Windows 10 Pro (64bit)
Intel i9-10900KF @4.9GHz
nvidia RTX-3080

Steps to reproduce:
1. load any track (preferable with cue points set)
2. jump to the cue point
3. in the waveform (but not the overview waveform) double RIGHT-click the cue point
4. the application crashes

Logs:
- mixxx.log does not tell a thing there
- having console open there is no message there either
- WinDbg seems to be freezing up Mixxx, so no attaching to the process there
- Crash-Dump (also attached to bug) says:
  FAULTING_SOURCE_LINE: D:\a\mixxx\mixxx\src\waveform\renderers\glslwaveformrenderersignal.cpp

  FAULTING_SOURCE_FILE: D:\a\mixxx\mixxx\src\waveform\renderers\glslwaveformrenderersignal.cpp

  FAULTING_SOURCE_LINE_NUMBER: 41

  FAULTING_SOURCE_CODE:
  No source found for 'D:\a\mixxx\mixxx\src\waveform\renderers\glslwaveformrenderersignal.cpp'

Full opened crash-dump can be found in pastebin -> https://pastebin.com/iiEUGyNf

[Marcel Schwettmann (feanturi)]

Due to other crashing issues I switched over from stable 2.3.3 to the 2.4-pre version and the bug does not seem to occur there. So maybe it is fixed already in the 2.4?

[ronso0 (ronso0)]

That was fixed and the PR was merged May 2021, so the fix is definitely in 2.3.3 (which is merged to 2.4/main frequently)
https://github.com/mixxxdj/mixxx/commit/70e3147d58502f0c9122d6d18ed02c9b0e4cd863

If you can still reproduce it with 2.3.3, please create a backtrace with this instructions
https://github.com/mixxxdj/mixxx/wiki/Creating-Backtraces#windows

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10818