ovn: db sync fails if all ips are allocated in the subnet and metadata port is missing an ip

[Jakub Libosvar]

If a user creates a tenant network with small subnet (like /30) and then manually deletes IP address from the metadata port and allocates all available IP addresses then db sync will fail when attempting to allocate a new IP address to the metadata port.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/853840

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/853840
Committed: https://opendev.org/openstack/neutron/commit/d237a2a83034fab809517a39dddee15995226131
Submitter: "Zuul (22348)"
Branch: master

commit d237a2a83034fab809517a39dddee15995226131
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 19 20:16:09 2022 +0000

    ovn: Don't fail db sync if new IP allocation fails for metadata

    There is a scenario where IP allocation pool is depleted but OVN
    metadata port got removed its IP manually. The DB sync script will
    attempt to allocate a new IP address if DHCP is enabled in the subnet.
    Since the pool has no available IP addresses an exception is raised and
    the whole db sync stops.

    This patch simply catches the exception, logs and error and continues
    syncing other resources.

    Closes-bug: #1987135
    Signed-off-by: Jakub Libosvar <email address hidden>
    Change-Id: Iaa7b0d7ceb244a38fddd7676066683bf2ca72341

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/854011

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/854012

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/854013

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854011
Committed: https://opendev.org/openstack/neutron/commit/de9e632e1464173ce474d0a3e2a4c10a49ebc117
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit de9e632e1464173ce474d0a3e2a4c10a49ebc117
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 19 20:16:09 2022 +0000

    ovn: Don't fail db sync if new IP allocation fails for metadata

    There is a scenario where IP allocation pool is depleted but OVN
    metadata port got removed its IP manually. The DB sync script will
    attempt to allocate a new IP address if DHCP is enabled in the subnet.
    Since the pool has no available IP addresses an exception is raised and
    the whole db sync stops.

    This patch simply catches the exception, logs and error and continues
    syncing other resources.

    Closes-bug: #1987135
    Signed-off-by: Jakub Libosvar <email address hidden>
    Change-Id: Iaa7b0d7ceb244a38fddd7676066683bf2ca72341
    (cherry picked from commit d237a2a83034fab809517a39dddee15995226131)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854012
Committed: https://opendev.org/openstack/neutron/commit/6f92ba9280793107563cf4ef059fa2b000121281
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 6f92ba9280793107563cf4ef059fa2b000121281
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 19 20:16:09 2022 +0000

    ovn: Don't fail db sync if new IP allocation fails for metadata

    There is a scenario where IP allocation pool is depleted but OVN
    metadata port got removed its IP manually. The DB sync script will
    attempt to allocate a new IP address if DHCP is enabled in the subnet.
    Since the pool has no available IP addresses an exception is raised and
    the whole db sync stops.

    This patch simply catches the exception, logs and error and continues
    syncing other resources.

    Closes-bug: #1987135
    Signed-off-by: Jakub Libosvar <email address hidden>
    Change-Id: Iaa7b0d7ceb244a38fddd7676066683bf2ca72341
    (cherry picked from commit d237a2a83034fab809517a39dddee15995226131)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/854013
Committed: https://opendev.org/openstack/neutron/commit/a6432b3943611d2d2f5ff3a22230abc181edc1ac
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a6432b3943611d2d2f5ff3a22230abc181edc1ac
Author: Jakub Libosvar <email address hidden>
Date: Fri Aug 19 20:16:09 2022 +0000

    ovn: Don't fail db sync if new IP allocation fails for metadata

    There is a scenario where IP allocation pool is depleted but OVN
    metadata port got removed its IP manually. The DB sync script will
    attempt to allocate a new IP address if DHCP is enabled in the subnet.
    Since the pool has no available IP addresses an exception is raised and
    the whole db sync stops.

    This patch simply catches the exception, logs and error and continues
    syncing other resources.

    Closes-bug: #1987135
    Signed-off-by: Jakub Libosvar <email address hidden>
    Change-Id: Iaa7b0d7ceb244a38fddd7676066683bf2ca72341
    (cherry picked from commit d237a2a83034fab809517a39dddee15995226131)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.0 release.