Design adjustments for Bootstrap 5

[Kristina Hoeppner]

Bootstrap 5 has been merged (bug #1915975) and there might be some design adjustments that need to be made.

[Evonne Cheung (evonne)]

Résumé add education entry is a bit hit and miss.

1.There is a active class in the file row after it has been removed in Résumé education entry.

To replicate:
Go to Résumé, click on Education tab, click on Add, upload a file or click on a file from table. Close modal, remove file from entry, click on add file again, there is still a yellow row background colour (active class in tr).

Expectation:
The file that is attached/added to the entry should have some visual indication that it is added, and the add button disabled or changed to a remove button. And if file is removed in the entry it should be reflected in the modal.

Reality:
The file that was removed is still visually inheriting the yellow background in the modal.

2. If you save the entry with a file attached that has been used before, it will fail, but the entry is still saved, just without the file. And if you add a different file, the entry is added as a different entry.

To replicate:
Go to Résumé, click on Education tab, click on Add, fill in form, choose a file from table that has already been attached to a previous entry. Close modal, click save. You will see error message at top, now attached a different file to the entry, save, the table will reload with two entries, one without attachments and one with.

Expectation:
It should only have one entry, the one with error message shouldn't have saved.

Reality:
It has two entries!

3. When you add another entry straight after without refreshing that page, the new form inherits the data from the previous entry in Qualification description textbox.

To replicate:
Go to Résumé, click on Education tab, click on Add, fill in form, make sure to fill in Qualification description. Save. Click on Add again, new form opens up and Qualification Description has been pre-filled with whatever was in the form for last entry. Refresh page and the pre-filled data is gone.

Expectation:
When adding new entry, the form shouldn't have anything filled.

Reality:
Qualifications description already has something in it.

[Evonne Cheung (evonne)]

#1 also happens in Employment and Achievements.

[Evonne Cheung (evonne)]

4. Not sure if this is something we can fix, it only happens in Firefox when scrollbars are not always showing (it's a setting). When content in modal requires scrolling down, it doesn't. The vertical scroll only scrolls the main frame, the modal is fixed, only way to scroll down is to click within the modal and use keyboard down arrow. You can semi see the modal scrollbar when you hover over it but can't grab a hold of it. If you turn the scrollbars on in the settings, it's fine.

To replicate:
Go to your own Account page, Edit, click on edit icon in About Me block, modal pops out, make sure your browser size is just a bit shorter than the full modal height, try to scroll down with scroll bar.

Expectation:
The scroll bar would scroll the modal part of the page down, the page behind that has been dulled out shouldn't move. OR there should be a scroll bar within the modal itself.

Reality:
The scroll bar scrolls the background page down and the modal doesn't move.

[Evonne Cheung (evonne)]

5. Plan that is a template, Task preview button doesn't work.

To replicate:
Add Plan, select Yes for Template, Save plan. Add a task, Select a Task Page in the dropdown, Save. In the table of tasks, click on the Task Preview button (the i icon), nothing happens. Not sure what is supposed to happen but Error message in console:

Uncaught TypeError: url is undefined
    isEmptyCollectionByPortfolioUrl http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:61
    setShowPortfolioClickEvents http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:75
    jQuery 8
    setShowPortfolioClickEvents http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:72
    <anonymous> http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:154
    jQuery 13
2 planview.js:61:5
    isEmptyCollectionByPortfolioUrl http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:61
    setShowPortfolioClickEvents http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:75
    jQuery 8
    setShowPortfolioClickEvents http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:72
    <anonymous> http://localhost:6142/gerrit/artefact/plans/js/planview.js?v=2980:154
    jQuery 13

This also occurs on demo.mahara.org currently.

[Evonne Cheung (evonne)]

6. On My Tags Page, getting ([[title/blocktype.annotation]]) for an Annotation list-group-item, but directly above it is an Annotation that didn't have that, not sure how that happened or even how to replicate it?

[Evonne Cheung (evonne)]

7. When you click on a Plan that has a tag from the My Tags page, it loads up the page with the Plan in modal, are the checkboxes in that list supposed to be clickable? if not should they be hidden instead?

[Evonne Cheung (evonne)]

8. After pressing the copy secret url button, it needs a reactive message in response, a message that displays "Copied to clipboard" or something, better accessibility.

[Evonne Cheung (evonne)]

9. Portfolio completion page action more dropdown menu is missing text in the last option, I'm assuming based on the icon it should be "return to portfolios"?

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13227

[Kristina Hoeppner (kris-hoeppner)]

9 doesn't seem to be a problem any more on my instance

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13262

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13263

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13265

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13266

[Robert Lyon (robertl-9)]

I've made patches for issues 1,2,6,7,8

Issue 5 is being handled by an existing patch

Issue 9 is already fixed in main

Issue 3 is hard to fix and not too big an issue as only the resume owner will see this problem

Will look into issue 4 now

[Robert Lyon (robertl-9)]

For issue 4 it looks like you need to have a non-default browser setting to cause the issue so it's not actually a Mahara issue but mahara + browser issue.

Will leave for now as one can always use default setting in browser (or another browser) for correct user experience

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13262
Committed: https://git.mahara.org/mahara/mahara/commit/9e59598799dce05915a5f54a9fbc0537a1aca23f
Submitter: "Gold <email address hidden>"
Branch: main

commit 9e59598799dce05915a5f54a9fbc0537a1aca23f
Author: Robert Lyon <email address hidden>
Date: Wed Oct 19 16:20:28 2022 +1300

Bug 1984139: Not open plan artefact in modal via 'My Tags' page

For point 7

- As the plan artefact is not normally shown in a modal

Change-Id: Ic79bae29ab4fe425f76f64f10e8f0aadc7e4a6e5
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13227
Committed: https://git.mahara.org/mahara/mahara/commit/29ebdcace03672f1b67dcda1a417b3b6d1277125
Submitter: "Gold <email address hidden>"
Branch: main

commit 29ebdcace03672f1b67dcda1a417b3b6d1277125
Author: Robert Lyon <email address hidden>
Date: Thu Oct 13 16:30:31 2022 +1300

Bug 1984139: JS to alert person that secret url copy is clicked

For point 8

- Having the copied link appear in popup modal

Change-Id: If333bcfe1d521b2550212140a4c5519a99c6d6bb
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13263
Committed: https://git.mahara.org/mahara/mahara/commit/3848b3a9007dd17828ea032123b62d637a2b8a83
Submitter: "Gold <email address hidden>"
Branch: main

commit 3848b3a9007dd17828ea032123b62d637a2b8a83
Author: Robert Lyon <email address hidden>
Date: Wed Oct 19 17:12:38 2022 +1300

Bug 1984139: Displaying the correct string on 'My Tags' page

For point 6

- Fetch the block type string from correct place if block is a subdir
of an artefact

Change-Id: I8e6c77e1cfeaac1092bfe7766291c9c802a61533
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13265
Committed: https://git.mahara.org/mahara/mahara/commit/41d0132c07ddd87a90c70f2719bf2003e8c9c850
Submitter: "Gold <email address hidden>"
Branch: main

commit 41d0132c07ddd87a90c70f2719bf2003e8c9c850
Author: Robert Lyon <email address hidden>
Date: Thu Oct 20 09:44:04 2022 +1300

Bug 1984139: JS for filebrowser selector highlight colour issue

For point 1

- The highlight color was not being removed when item was unselected

This is an issue that was made in commit 9139adb73f2d00b42cca320cc9afe421bc7391fb
when the old mochikit code was changed and the line was changed from
removing a class to adding a class by mistake

Change-Id: I5bae2680f41ec33557b91e287c652a93f6001c95
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13266
Committed: https://git.mahara.org/mahara/mahara/commit/6f0e799178ebd924f90eda847b7c1106a7d68621
Submitter: "Gold <email address hidden>"
Branch: main

commit 6f0e799178ebd924f90eda847b7c1106a7d68621
Author: Robert Lyon <email address hidden>
Date: Thu Oct 20 10:39:35 2022 +1300

Bug 1984139: Resume add composite to have a validate function

For point 2

- The validation was being done as part of the submission after the
item was created.

We need to have a validation function to do the file attachment check
before the submission so we don't create a record.

Change-Id: I01ab672a677e4c0670f7e85debf68bb6822283e4
Signed-off-by: Robert Lyon <email address hidden>

[Robert Lyon (robertl-9)]

All the bits we wish to fix at this time are done so will close report

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13231
Committed: https://git.mahara.org/mahara/mahara/commit/5f5f18aa451367b61811350e5cf6ff98151dd724
Submitter: "Gold <email address hidden>"
Branch: main

commit 5f5f18aa451367b61811350e5cf6ff98151dd724
Author: Robert Lyon <email address hidden>
Date: Fri Oct 14 17:33:05 2022 +1300

Bug 1939364: fails on plans with no parent

Also mentioned in Bug 1984139 - for point 5
When copying from template

and viewing them via 'i' button

Change-Id: Ibd5c4883193a99e1b798ccf479b9b754423905f8
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13281

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13301

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13300

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13303

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13302

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13302
Committed: https://git.mahara.org/mahara/mahara/commit/663d5b12a957303845de91e1d2df2f5bd0e68b93
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 663d5b12a957303845de91e1d2df2f5bd0e68b93
Author: Robert Lyon <email address hidden>
Date: Thu Oct 20 09:44:04 2022 +1300

Bug 1984139: JS for filebrowser selector highlight colour issue

For point 1

- The highlight color was not being removed when item was unselected

This is an issue that was made in commit 9139adb73f2d00b42cca320cc9afe421bc7391fb
when the old mochikit code was changed and the line was changed from
removing a class to adding a class by mistake

Change-Id: I5bae2680f41ec33557b91e287c652a93f6001c95
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13281
Committed: https://git.mahara.org/mahara/mahara/commit/1f411585147ddb7654af23b0993f52f3906770e0
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 1f411585147ddb7654af23b0993f52f3906770e0
Author: Robert Lyon <email address hidden>
Date: Thu Oct 13 16:30:31 2022 +1300

Bug 1984139: JS to alert person that secret url copy is clicked

For point 8

- Having the copied link appear in popup modal

Change-Id: If333bcfe1d521b2550212140a4c5519a99c6d6bb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 29ebdcace03672f1b67dcda1a417b3b6d1277125)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13301
Committed: https://git.mahara.org/mahara/mahara/commit/ffe18b9652fd4ea2f781f17fb88598da50a5d6ca
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit ffe18b9652fd4ea2f781f17fb88598da50a5d6ca
Author: Robert Lyon <email address hidden>
Date: Wed Oct 19 17:12:38 2022 +1300

Bug 1984139: Displaying the correct string on 'My Tags' page

For point 6

- Fetch the block type string from correct place if block is a subdir
of an artefact

Change-Id: I8e6c77e1cfeaac1092bfe7766291c9c802a61533
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13300
Committed: https://git.mahara.org/mahara/mahara/commit/1c6d4a538b0b831ff75fe7a249ff252541c858b7
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 1c6d4a538b0b831ff75fe7a249ff252541c858b7
Author: Robert Lyon <email address hidden>
Date: Wed Oct 19 16:20:28 2022 +1300

Bug 1984139: Not open plan artefact in modal via 'My Tags' page

For point 7

- As the plan artefact is not normally shown in a modal

Change-Id: Ic79bae29ab4fe425f76f64f10e8f0aadc7e4a6e5
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13303
Committed: https://git.mahara.org/mahara/mahara/commit/c2d3086c25ba8641079472d14f97551de580aa0a
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit c2d3086c25ba8641079472d14f97551de580aa0a
Author: Robert Lyon <email address hidden>
Date: Thu Oct 20 10:39:35 2022 +1300

Bug 1984139: Resume add composite to have a validate function

For point 2

- The validation was being done as part of the submission after the
item was created.

We need to have a validation function to do the file attachment check
before the submission so we don't create a record.

Change-Id: I01ab672a677e4c0670f7e85debf68bb6822283e4
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13282

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13282
Committed: https://git.mahara.org/mahara/mahara/commit/5a4a38df36232c62af2da996f3bccfda325a63a5
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.10_DEV

commit 5a4a38df36232c62af2da996f3bccfda325a63a5
Author: Robert Lyon <email address hidden>
Date: Fri Oct 14 17:33:05 2022 +1300

Bug 1939364: fails on plans with no parent

Also mentioned in Bug 1984139 - for point 5
When copying from template

and viewing them via 'i' button

Change-Id: Ibd5c4883193a99e1b798ccf479b9b754423905f8
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5f5f18aa451367b61811350e5cf6ff98151dd724)