Make source address available for transit slips

[Benjamin Murphy]

EG 3.7.2

For Transit and Transit Hold receipt templates, it would be nice to have the address of the source of the transit available, so that if the material gets lost in route, that info could be printed on the slip.

The elements available are defined here:
Evergreen\Open-ILS\web\js\ui\default\staff\circ\services\circ.js
line 1843 to 1853

            if (data.transit) {                // route_dialog includes the "route to holds shelf"                 // dialog, which has no transit                print_context.transit = egCore.idl.toHash(data.transit);                print_context.dest_courier_code = data.dest_courier_code;                if (data.address) {                    print_context.dest_address = egCore.idl.toHash(data.address);                }                print_context.dest_location =                    egCore.idl.toHash(egCore.org.get(data.transit.dest()));                print_context.copy.status = egCore.idl.toHash(print_context.copy.status);            }

[Llewellyn Marshall (lbmarshallv)]

I created a patch on the working repository that adds source_address and source_location to the transit slips.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/lew/lp-1983991-source-on-transit-slip

[Gina Monti (gmonti90)]

Feedback Fest 9/22

Question before I sign-off on this: is what's in the addresses saved under Server Admin > Organizational Units directly effect what's in the database or are these two areas not related?

[Terran McCanna (tmccanna)]

If I'm reading it correctly, it looks like it's grabbing the address from Server Admin > Organizational Units.

[Gina Monti (gmonti90)]

Ok! I don't think it's pulling info from there. Branches 1-3 have addresses filled out and only branch 1 transit slips show the address.

[Terran McCanna (tmccanna)]

I'm not getting consistent results either. It works sometimes (typically right after clearing cache), but then after a few subsequent scans it will start pulling data from the wrong branch or not at all. Examples attached.

[Terran McCanna (tmccanna)]

Also, the Transit Slip default template doesn't have the helper text added to it (the Hold Transit Slip does):

* source_location.name - name of source library
* source_location.shortname
* source_address.street1
* source_address.street2
* source_address.city
* source_address.state
* source_address.post_code

[Llewellyn Marshall (lbmarshallv)]

Terran, I followed the steps to recreate the issue and I also got the incorrect transit source. I kicked off the transit from BR2 and the printout said BR1 (with no holds & ill address). Then I went into the transit list admin page and found that the source was incorrect on there as well. Seems like this could be unrelated to the transit slip itself. Weirdly, all of the other transits I kicked off had the correct source and destination both on the slip and the list.

[Terran McCanna (tmccanna)]

Hmm, maybe there's a problem on my test server. I'll rebuild it today and try again.

[Terran McCanna (tmccanna)]

Ah! It was a testing issue on my part - I was switching between branches but using barcodes that were already in transit from a different branch, so it showed the original transit location and not my current location. If I canceled the transit before scanning, then it showed up properly. So yes, that works.

However, comment #8 - the helper code should still be added to the Transit Slip default template the same way it is in the default Hold Transit Slip template.

[Llewellyn Marshall (lbmarshallv)]

I've just added the source_address/source_location to the transit slip's documentation on my branch. Thanks for pointing that out!

[Terran McCanna (tmccanna)]

Looks good! My signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp-1983991-source-on-transit-slip-signoff

[Llewellyn Marshall (lbmarshallv)]

Squashed all the commits and added my signoff above Terran's
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=51996ee2f73eb3b3c97623f3ba8bc90fcfe2cc6e

[Llewellyn Marshall (lbmarshallv)]

added another commit d2702631aa862e74527ae5510f3af08ef7f3305a that fixes an issue that occurred when both source and destination holds addresses were NULL.

[Jane Sandberg (sandbergja)]

Thanks, Llewellyn and Terran! Merged for inclusion in 3.10.

Llewellyn, just a note that I modified your commit messages to include the launchpad bug number.