System Controller failed to unlock in Debian due to Posgres failure

[Tee Ngo]

Brief Description
-----------------
System Controller failed to unlock in Debian due to Postgres failure. Standard system in Debian is also affected

Severity
--------
Critical

Steps to Reproduce
------------------
Bring up the system controller in Debian

Expected Behavior
------------------
Controller-0 is unlocked successfully.
Note: At this point duplex support in Debian is not yet ready.

Actual Behavior
----------------
Postgres failed to come up after the unlock due to obsolete config parameter checkpoint_segments

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Distributed Cloud

Branch/Pull Time/Commit
-----------------------
2022-08-02 master build (Debian)

Last Pass
---------
First time bringing up the system controller

Timestamp/Logs
--------------
postgres@controller-0:/var/home/sysadmin$ /usr/lib/postgresql/13/bin/postgres -D /var/lib/postgresql/22.06 -c config_file=/etc/postgresql/postgresql.conf
2022-08-03 08:32:13.388 GMT [3355091] LOG: unrecognized configuration parameter "checkpoint_segments" in file "/etc/postgresql/postgresql.conf" line 799
2022-08-03 08:32:13.388 GMT [3355091] FATAL: configuration file "/etc/postgresql/postgresql.conf" contains errors

Test Activity
-------------
Feature Testing

Workaround
----------

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/852184

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/852184
Committed: https://opendev.org/starlingx/stx-puppet/commit/e719b2ef24824052de6aa91632474dee7e828122
Submitter: "Zuul (22348)"
Branch: master

commit e719b2ef24824052de6aa91632474dee7e828122
Author: Tee Ngo <email address hidden>
Date: Thu Aug 4 11:25:07 2022 -0400

    Update postgres config for Debian

    The checkpoint_segments config parameter was deprecated in Postgres9.5.
    It has been replaced by min_wal_size and max_wal_size. This commit
    updates postgres puppet manifest to reflect the change to enable initial
    unlock for system controller as well as standard system in Debian.

    Test Plan:
      - Verify successful bring up of the system controller in CentOS.
      - Verify successful unlock of controller-0 of the system controller
        in Debian.
        Note: at this point, support of duplex system in Debian is not
              available.

    Closes-Bug: 1983598
    Change-Id: Ie277728372393fff259c131227e3cf9f2a7fe42a
    Signed-off-by: Tee Ngo <email address hidden>