List of undercloud services generated from tripleo-common is not current

[Mikolaj Ciecierski]

According to a comment in inventory.py[1] list of undercloud services is static. It seems to be out of date and has not been updated for some time(the last change 3 years ago).[2]
There were changes in services running on undercloud since then, for instance, from wallaby there is no tripleo_nova_compute tripleo_heat_engine on undercloud. I'm not sure about other enlisted services and if there aren't any missing services.

The fact that the list is out of date affects tripleo-validations as undercloud_service_status
validations rely on it.[2] (undercloud_service_list: A list of services actually coming from the tripleo-ansible-inventory)

[1]https://opendev.org/openstack/tripleo-common/src/branch/master/tripleo_common/inventory.py#L311
[2]https://opendev.org/openstack/tripleo-common/commit/6942ac007f66fdf22a1a7678da608b28eebc6b4e
[3] https://docs.openstack.org/tripleo-validations/latest/roles/role-undercloud_service_status.html

[Mikolaj Ciecierski (mciecierski)]

Fixed with https://review.opendev.org/c/openstack/tripleo-common/+/853272

[Jiri Podivin (jpodivin)]

I'll take care of backports.

[Jiri Podivin (jpodivin)]

Please note that there are merge conflicts, so it may be necessary to backport multiple patches to get a clean cherry pick. This in turn will cause a delay in final backport.

[Jiri Podivin (jpodivin)]

Wallaby backport merged https://review.opendev.org/c/openstack/tripleo-common/+/855871

[Jiri Podivin (jpodivin)]

Fix released in tripleo-validations-15.4.1