[OVN] metadata does not work when using neutron-dhcp-agent for baremetal ports

[Michal Nasiadka]

When using neutron-dhcp-agent for Ironic/baremetal ports - DHCP injects a route to 169.254.169.254 via the routers ip.
That's incorrect, because neutron ovn metadata agent is listening on a dedicated port (network:distributed).

Example:

# ip r l
default via 10.209.0.1 dev eno1
10.209.0.0/16 dev eno1 proto kernel scope link src 10.209.3.225
169.254.169.254 via 10.209.0.1 dev eno1
172.17.0.0/16 dev docker0 proto kernel scope link src 172.17.0.1 linkdown

ping 169.254.169.254
PING 169.254.169.254 (169.254.169.254) 56(84) bytes of data.
^C
--- 169.254.169.254 ping statistics ---
2 packets transmitted, 0 received, 100% packet loss, time 1017ms

# ip r d 169.254.169.254
# ip r a 169.254.169.254 via 10.209.0.2

# curl 169.254.169.254
1.0
2007-01-19
2007-03-01
2007-08-29
2007-10-10
2007-12-15
2008-02-01
2008-09-01
2009-04-04

OVN version: 21.12
OVS version: 2.16.0
OpenStack release: Wallaby

[yatin (yatinkarel)]

Proposed https://review.opendev.org/c/openstack/neutron/+/886988

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/886988
Committed: https://opendev.org/openstack/neutron/commit/82f2a21d1c9e27999d3fd7006a7ecf961039a370
Submitter: "Zuul (22348)"
Branch: master

commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/900195

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/900196

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/900197

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/900198

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/900199

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/900200

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/900195
Committed: https://opendev.org/openstack/neutron/commit/2ecb7084fe33b27749bcd2a9098437474e5ce300
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 2ecb7084fe33b27749bcd2a9098437474e5ce300
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e
    (cherry picked from commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/900198
Committed: https://opendev.org/openstack/neutron/commit/4b1e0bc5e4e94560ff91e76df908c32b574dd565
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 4b1e0bc5e4e94560ff91e76df908c32b574dd565
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e
    (cherry picked from commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/900196
Committed: https://opendev.org/openstack/neutron/commit/07c3eb49c53a922aae795b37791117f697874f03
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 07c3eb49c53a922aae795b37791117f697874f03
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e
    (cherry picked from commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/900197
Committed: https://opendev.org/openstack/neutron/commit/d869affee85272e90a036e7bdb062fd8f4f1106d
Submitter: "Zuul (22348)"
Branch: stable/zed

commit d869affee85272e90a036e7bdb062fd8f4f1106d
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Conflicts:
            neutron/agent/linux/dhcp.py

    The conflict was just simple indent and formatting which needed
    manual resolution

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e
    (cherry picked from commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/900199
Committed: https://opendev.org/openstack/neutron/commit/a616d6ac9128102fed05180284e9fec4e6239f9b
Submitter: "Zuul (22348)"
Branch: stable/xena

commit a616d6ac9128102fed05180284e9fec4e6239f9b
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e
    (cherry picked from commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/900200
Committed: https://opendev.org/openstack/neutron/commit/2d6f514442a5100aa3453e118173ab462573e4cd
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2d6f514442a5100aa3453e118173ab462573e4cd
Author: yatinkarel <email address hidden>
Date: Mon Jun 26 21:17:48 2023 +0530

    [DHCP agent] Add route to OVN metadata port if exists

    When DHCP agent is deployed with ml2/ovn for baremetal
    ports, ovn metadata route is not added.

    This patch adds route via ovn metadata port if exists
    so baremetal nodes can fetch metadata.

    Closes-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: I12e496d70bb6db707b317d0aeb6e4edd6c43571e
    (cherry picked from commit 82f2a21d1c9e27999d3fd7006a7ecf961039a370)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/901680

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901680
Committed: https://opendev.org/openstack/neutron/commit/56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49
Submitter: "Zuul (22348)"
Branch: master

commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/901716

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/901717

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/901718

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/901719

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/901720

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/901781

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/901827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901827
Committed: https://opendev.org/openstack/neutron/commit/0afa24d9af9425036b452ca3ffac685f2a30d47d
Submitter: "Zuul (22348)"
Branch: master

commit 0afa24d9af9425036b452ca3ffac685f2a30d47d
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/901847

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/901848

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/901849

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/901850

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/901851

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/901852

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901847
Committed: https://opendev.org/openstack/neutron/commit/e536483b9be10fe60b1b8d766626f973179b3eb4
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit e536483b9be10fe60b1b8d766626f973179b3eb4
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb
    (cherry picked from commit 0afa24d9af9425036b452ca3ffac685f2a30d47d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901716
Committed: https://opendev.org/openstack/neutron/commit/0edb776c6ade8f5836a9cb4ca35df7c5d3068fd4
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 0edb776c6ade8f5836a9cb4ca35df7c5d3068fd4
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2
    (cherry picked from commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901849
Committed: https://opendev.org/openstack/neutron/commit/69e0dacd053454f38e724616138a519e7acbb203
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 69e0dacd053454f38e724616138a519e7acbb203
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb
    (cherry picked from commit 0afa24d9af9425036b452ca3ffac685f2a30d47d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901719
Committed: https://opendev.org/openstack/neutron/commit/481582a7f18db1939c304a857c6d471fee121dd4
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 481582a7f18db1939c304a857c6d471fee121dd4
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2
    (cherry picked from commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901851
Committed: https://opendev.org/openstack/neutron/commit/2f5ca655d694ec4d0d7337b379b4d0ff2c31cd3e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 2f5ca655d694ec4d0d7337b379b4d0ff2c31cd3e
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb
    (cherry picked from commit 0afa24d9af9425036b452ca3ffac685f2a30d47d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901720
Committed: https://opendev.org/openstack/neutron/commit/1d26d016ea9f9cde3d71147fa2d83dd3b7ea9c93
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 1d26d016ea9f9cde3d71147fa2d83dd3b7ea9c93
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2
    (cherry picked from commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901718
Committed: https://opendev.org/openstack/neutron/commit/cbebc3dd8a276c06e34ede9e25b98b18118f7682
Submitter: "Zuul (22348)"
Branch: stable/zed

commit cbebc3dd8a276c06e34ede9e25b98b18118f7682
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2
    (cherry picked from commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901848
Committed: https://opendev.org/openstack/neutron/commit/ae90f380a8144e5506a45c717093901452ebdace
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit ae90f380a8144e5506a45c717093901452ebdace
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb
    (cherry picked from commit 0afa24d9af9425036b452ca3ffac685f2a30d47d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901717
Committed: https://opendev.org/openstack/neutron/commit/f81549c0e5f131191a81e7dd1c44176c4e9c7af3
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit f81549c0e5f131191a81e7dd1c44176c4e9c7af3
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2
    (cherry picked from commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901850
Committed: https://opendev.org/openstack/neutron/commit/a4d2598a50ce17ea2a443faae122526118a0298d
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit a4d2598a50ce17ea2a443faae122526118a0298d
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb
    (cherry picked from commit 0afa24d9af9425036b452ca3ffac685f2a30d47d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901852
Committed: https://opendev.org/openstack/neutron/commit/0e0ea1546c9ab06b8f467308980ca5e9ab57e78a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 0e0ea1546c9ab06b8f467308980ca5e9ab57e78a
Author: yatinkarel <email address hidden>
Date: Fri Nov 24 17:54:49 2023 +0530

    [DHCP agent] Fetch OVN Metadata port from plugin

    OVN metadata port from NetworkCache is being used and fixed_ips
    for it were not available at the time network was added into
    the cache. So let's re fetch it if it is available in the cache.

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Ie0ec43566fa2b3e13b4917493336ce1519c9b6bb
    (cherry picked from commit 0afa24d9af9425036b452ca3ffac685f2a30d47d)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901781
Committed: https://opendev.org/openstack/neutron/commit/c428175eea598d09f8a882e9a8c021afba102caf
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c428175eea598d09f8a882e9a8c021afba102caf
Author: yatinkarel <email address hidden>
Date: Wed Nov 22 21:03:02 2023 +0530

    [DHCP agent] Fix route to OVN metadata port for non-isolated networks

    This was missed in the original fix[1] during 5th patch set.
    When ovn metadata port exists it's ip should be used as route
    irrespective of subnet is isolated or not.

    [1] https://review.opendev.org/c/openstack/neutron/+/886988

    Related-Bug: #1982569
    Related-Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2213862
    Change-Id: Icd84685c37fffa20e4fc9c5522f77bc63e2565f2
    (cherry picked from commit 56172ed5aef07d278e0f9cd6bcd5164f3f0ffa49)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 24.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Miro Tomaska <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/903572
Reason: Superseded by https://review.opendev.org/c/openstack/neutron/+/904872

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/904872
Committed: https://opendev.org/openstack/neutron/commit/637e7a50077f215dbaa25ebde6f6ca792ef4955b
Submitter: "Zuul (22348)"
Branch: master

commit 637e7a50077f215dbaa25ebde6f6ca792ef4955b
Author: Miro Tomaska <email address hidden>
Date: Fri Jan 5 13:42:12 2024 -0500

    Make get_ports RPC method common for the DHCP and Metadata agent

    This patch is the initial implementation on the suggestion
    from this patch[1].

    The DHCP agent can query the existing `get_ports` RPC method because
    this method is already exposed in the MetadataRpcCallback(server side)
    which runs under the same topic(PLUGIN) and namespace(None). The benefit
    here is that there is no change needed to the API, however it does
    go against how we historically setup the RPC layer between a server and client.

    [1] https://review.opendev.org/c/openstack/neutron/+/903572/comments/3d4e0453_4b4d2ab6

    Related-Bug: #1982569
    Change-Id: Icd7c55d2a5103bdbd90907b1dbfb9ccfe34c020a

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/905906

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Miro Tomaska <email address hidden>" on branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/neutron/+/905906
Reason: creates many small import conflicts, which can cause issue in the future. Code is still functional without this patch

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/906296

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/906297

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/906299

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/906300

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/906401

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Miro Tomaska <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/906401
Reason: Decided that cherry pick is not required, only back porting up to 2023.1

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Miro Tomaska <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/906299
Reason: Decided that cherry pick is not required, only back porting up to 2023.1

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Miro Tomaska <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/906297
Reason: Decided that cherry pick is not required, only back porting up to 2023.1

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Miro Tomaska <email address hidden>" on branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/906300
Reason: Decided that cherry pick is not required, only back porting up to 2023.1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/905906
Committed: https://opendev.org/openstack/neutron/commit/3b6e642a670462539a15b91dd2a430ec2ecaa1a5
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 3b6e642a670462539a15b91dd2a430ec2ecaa1a5
Author: Miro Tomaska <email address hidden>
Date: Fri Jan 5 13:42:12 2024 -0500

    Make get_ports RPC method common for the DHCP and Metadata agent

    This patch is the initial implementation on the suggestion
    from this patch[1].

    The DHCP agent can query the existing `get_ports` RPC method because
    this method is already exposed in the MetadataRpcCallback(server side)
    which runs under the same topic(PLUGIN) and namespace(None). The benefit
    here is that there is no change needed to the API, however it does
    go against how we historically setup the RPC layer between a server and client.

    [1] https://review.opendev.org/c/openstack/neutron/+/903572/comments/3d4e0453_4b4d2ab6

    Merge Conflicts:
            neutron/agent/linux/dhcp.py#L1216
            OVN_METADATA_PREFIX is no present in ovn_constants, using 'ovnmeta-'
            string literal instead

            neutron/tests/unit/agent/linux/test_dhcp.py
            Manually merged `get` method to the Dictable class
    Related-Bug: #1982569
    Change-Id: Icd7c55d2a5103bdbd90907b1dbfb9ccfe34c020a
    (cherry picked from commit 637e7a50077f215dbaa25ebde6f6ca792ef4955b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/906296
Committed: https://opendev.org/openstack/neutron/commit/09c1c61677b538bcf9179a8bf3db3f14bdda49dc
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 09c1c61677b538bcf9179a8bf3db3f14bdda49dc
Author: Miro Tomaska <email address hidden>
Date: Fri Jan 5 13:42:12 2024 -0500

    Make get_ports RPC method common for the DHCP and Metadata agent

    This patch is the initial implementation on the suggestion
    from this patch[1].

    The DHCP agent can query the existing `get_ports` RPC method because
    this method is already exposed in the MetadataRpcCallback(server side)
    which runs under the same topic(PLUGIN) and namespace(None). The benefit
    here is that there is no change needed to the API, however it does
    go against how we historically setup the RPC layer between a server and client.

    [1] https://review.opendev.org/c/openstack/neutron/+/903572/comments/3d4e0453_4b4d2ab6

    Related-Bug: #1982569
    Change-Id: Icd7c55d2a5103bdbd90907b1dbfb9ccfe34c020a
    (cherry picked from commit 3b6e642a670462539a15b91dd2a430ec2ecaa1a5)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.