Some jobs broken post pyroute2 update to 0.7.1

[yatin]

pyroute2 updated to 0.7.1 with https://review.opendev.org/c/openstack/requirements/+/849790, since then couple of jobs are broken, like:-

- https://zuul.opendev.org/t/openstack/builds?job_name=neutron-ovs-grenade-dvr-multinode&branch=master
- https://zuul.opendev.org/t/openstack/builds?job_name=neutron-ovs-tempest-dvr-ha-multinode-full&branch=master
- https://zuul.openstack.org/builds?job_name=neutron-functional-with-uwsgi&branch=master

Example failures:-
https://37a49967c371d50badcf-d0788a990c172de672e24591209c14b2.ssl.cf5.rackcdn.com/849122/8/check/neutron-functional-with-uwsgi/1971bae/testr_results.html

Failing as:-
ft7.4: neutron.tests.functional.privileged.agent.linux.test_ip_lib.RuleTestCase.test_add_rule_iptesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py", line 182, in func
    return f(self, *args, **kwargs)
  File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/privileged/agent/linux/test_ip_lib.py", line 323, in test_add_rule_ip
    priv_ip_lib.add_ip_rule(self.namespace, src=ip_address,
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.8/site-packages/oslo_privsep/priv_context.py", line 271, in _wrap
    return self.channel.remote_call(name, args, kwargs,
  File "/home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/lib/python3.8/site-packages/oslo_privsep/daemon.py", line 215, in remote_call
    raise exc_type(*result[2])
pyroute2.netlink.exceptions.NetlinkError: (22, 'Invalid argument')

testtools.matchers._impl.MismatchError: !=:
reference = {'from': '0.0.0.0/0',
 'iif': 'fpr-663cc9d3-b',
 'priority': '2852018311',
 'table': '2852018311',
 'type': 'unicast'}
actual = {'from': '0.0.0.0/0',
 'iif': 'fpr-663cc9d3-b',
 'priority': '2852018311',
 'table': '2852018311',
 'type': 'unspecified'}

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_ce1/849122/8/check/neutron-ovs-tempest-dvr-ha-multinode-full/ce10281/testr_results.html
https://d0b0b53d30de16fbad20-5f381a9e8c14b627196c6ef3340b4d4e.ssl.cf5.rackcdn.com/849122/8/check/neutron-ovs-grenade-dvr-multinode/2a568da/testr_results.html

^ jobs failing at SSH timeout

[Lajos Katona (lajos-katona)]

pyroute2 bump to 0.7.1 revert patch:
https://review.opendev.org/c/openstack/requirements/+/850034

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Note in iproute.rule [1], "table" parameter is mandatory (at least for IPv6 addresses).

[1]https://github.com/svinota/pyroute2/blob/ae751ac6961171f9bfc7e0dd2af6f70ad8c8d678/pyroute2/iproute/linux.py#L2251

[Lajos Katona (lajos-katona)]

By the way, the functional with pyroute2 master seems to be "predicted" the problem:
https://zuul.openstack.org/builds?job_name=neutron-functional-with-pyroute2-master

I have to check the logs, but as I see compared to opensearch result (see [1]) it was a bit faster.

[1]: https://opensearch.logs.openstack.org/_dashboards/app/discover/?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-7d,to:now))&_a=(columns:!(_source),filters:!(),index:'94869730-aea8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:'message:%22pyroute2.netlink.exceptions.NetlinkError:%20(22,%20!'Invalid%20argument!')%22'),sort:!())

[Lajos Katona (lajos-katona)]

Most probably this pr was which changed how ip rule works:
https://github.com/svinota/pyroute2/commit/511ddadbc92e0328daed3606bd01ea77fe3cf192

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

There is another error in ip.neigh "dump" command. IPv6 is not shown in this command. I'll open a bug in pyroute2 and accept the revert of requirements.

Then we'll need to blacklist this version 0.7.1.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/850223

[Gregory Thiemonge (gthiemonge)]

FYI I have proposed a PR to fix a bug with ip rule in 0.7.1: https://github.com/svinota/pyroute2/pull/965

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Once https://review.opendev.org/c/openstack/requirements/+/850295 is merged, we'll consider this bug as resolved. Then we'll bump the pyroute2 version to newer version, but that should be tracked in other bug.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/850223
Committed: https://opendev.org/openstack/neutron/commit/47a0278812499add333497efe15b7fb176203f74
Submitter: "Zuul (22348)"
Branch: master

commit 47a0278812499add333497efe15b7fb176203f74
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Sat Jul 9 01:04:59 2022 +0000

    Add a default table in "ip rule" command

    Now it is mandatory, at least for IPv6 addresses, to define a table
    when an IP rule is added. The default table selected is "default"
    (table=253). In any case, all commands calling this method right now are
    specifying the table in the kwargs.

    Partial-Bug: #1981963
    Change-Id: Ia44ac34ca9b91719a86f4d573c9777a4708d69a4