multi-value attributes in declarations are not properly validated

[Emilia Torino]

Given a snap.yaml that contains multiple values in attributes, such as:

fram-devices:
  interface: custom-device
  devices:
  - /dev/mtd[0-9]
  - /dev/chunkfs/chunkfs[0-2]
  read-devices:
  - /dev/chunkfs/geom
  - /dev/chunkfs/stats
  - /dev/chunkfs/sizes

And a declaration which supports this definition:

"custom-device": {
 "allow-installation": [
      {
        "on-store": [
          "honeywell-international-inc"
        ],
        "slot-attributes": {
          "devices": [
            "/dev/mtd\\[0-9\\]",
            "/dev/chunkfs/chunkfs\\[0-2\\]"
          ],
          "read-devices": [
            "/dev/chunkfs/geom",
            "/dev/chunkfs/stats",
            "/dev/chunkfs/sizes"
          ]
        },
        "slot-names": [
          "fram-devices"
        ]
      }
    ]
}

review-tools fails to review with the following error:
declaration-snap-v2:slots_installation:fram-devices:custom-device
    human review required due to 'allow-installation' constraint (slot-names)

[Alex Murray (alexmurray)]

I think this is expected - the snap declaration should use regex's for matching these attributes - something like the following I think (off the top of my head, this is untested):

"custom-device": {
 "allow-installation": [
      {
        "on-store": [
          "honeywell-international-inc"
        ],
        "slot-attributes": {
          "devices": "/dev/(mtd\\[0-9\\]|chunkfs/chunkfs\\[0-2\\])",
          "read-devices": "/dev/chunkfs/(geom|stats|sizes)"
        },
        "slot-names": [
          "fram-devices"
        ]
      }
    ]
}