Follow up to Stripe payment intents bug

[Terran McCanna]

This is a follow up to bug 1965579 - we only fixed the problem for grocery bills in the first fix that has already been committed. This should fix it for circulation bills as well. (Patch coming in a moment.)

[Terran McCanna (tmccanna)]

My proposed fix at:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1981628-opac-negative-bills-part2

[Jason Etheridge (phasefx)]

Terran,

I've signed off on this but only in conjunction with my follow-up commit:
collab/phasefx/lp1981628-follow-up @ working/Evergreen.git

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1981628-follow-up

It works for me with Boopac and TPAC, but more permutations with testing negative bills welcome.

Thanks!

[Jason Boyer (jboyer)]

Something I'm noticing as I look at this for Bug Squashing Week, now there's no alert for users to seek out a staff member to determine why they can't pay their bills. I do like the idea of setting myopac_cc_allowed to 0 when an issue pops up to disable all of the payment buttons at once, but there does need to be some mechanism to display the "There are negative bills on your account..." message.

[Terran McCanna (tmccanna)]

I agree with Jason B.

[Terran McCanna (tmccanna)]

My feeling is that if there are negative bills then the patron should see the alert to contact their library about them regardless of whether or not online payments are allowed. So, this additional followup separates that alert from the myopac_cc_allowed logic.

This also makes some minor display tweaks to the BooPAC:
- Applies the Bootstrap 'alert-warning' to the negative bills message in the BooPAC.
- Adds a page header.
- Changes the styling and wording of the grocery charges heading to match the circulation charges heading.
- Changes the styling of the grocery and circulation tables to be consistent with each other.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1981623-follow-up-3

[Terran McCanna (tmccanna)]

FYI, we've been using this in production for 2 months now.

[Terran McCanna (tmccanna)]

FYI, Blake indicated this needed a rebase, but I tried applying it to a fresh master branch and it picked cleanly for me. Removing the needsrebase tag.

[Jason Etheridge (phasefx)]

Terran, I've pushed a rebased (it was clean for me too) branch with my signoff. Looks good to me!

[Galen Charlton (gmc)]

Pushed all the way down to rel_3_8. Thanks, Terran and Jason!