Both cinder HA services not restarted when config changes

[Alan Bishop]

When both cinder-backup and cinder-volume are deployed HA under pcmk, and a stack update causes a change in cinder's config, only the cinder-backup service is restarted. The cinder-volume service is not restarted.

The problem is due to the tripleo_ha_wrapper ansible role using a single marker file for detecting when the config changes. When processing the config changes for the cinder-backup service, the service is restarted and the marker file is updated to indicate the latest applied config. Then, when the cinder-volume service is processed, the marker file makes it appear as if the service is already running the latest config, and therefore the cinder-volume service doesn't get restarted. The tripleo_ha_wrapper ansible role needs to be told to use separate marker files for each cinder HA service.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/849710

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/849710
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/7d76af34f54aa159b0e52d132705659be69b23a1
Submitter: "Zuul (22348)"
Branch: master

commit 7d76af34f54aa159b0e52d132705659be69b23a1
Author: Alan Bishop <email address hidden>
Date: Mon Jul 11 14:17:00 2022 -0700

    Fix restarting cinder HA services on config change

    Specify the tripleo_ha_wrapper ansible role use a separate marker
    file to detect when it should restart the cinder-backup and
    cinder-volume services. This ensures both services get restarted
    when the config changes. Unless a separate marker file is used
    for each service, only the first one (cinder-backup) gets
    restarted.

    Closes-Bug: #1981591
    Change-Id: Ib5c06ab5169942ddaf56a46ad7f14e9497b7e550

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/850106

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/850106
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/77d0ca4448599e6016c91361a050e7832cc9f970
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 77d0ca4448599e6016c91361a050e7832cc9f970
Author: Alan Bishop <email address hidden>
Date: Mon Jul 11 14:17:00 2022 -0700

    Fix restarting cinder HA services on config change

    Specify the tripleo_ha_wrapper ansible role use a separate marker
    file to detect when it should restart the cinder-backup and
    cinder-volume services. This ensures both services get restarted
    when the config changes. Unless a separate marker file is used
    for each service, only the first one (cinder-backup) gets
    restarted.

    Closes-Bug: #1981591
    Change-Id: Ib5c06ab5169942ddaf56a46ad7f14e9497b7e550
    (cherry picked from commit 7d76af34f54aa159b0e52d132705659be69b23a1)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/850354

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/850354
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/930648ce1f86e082061fd33aa5823bacdb668d8e
Submitter: "Zuul (22348)"
Branch: stable/train

commit 930648ce1f86e082061fd33aa5823bacdb668d8e
Author: Alan Bishop <email address hidden>
Date: Mon Jul 11 14:17:00 2022 -0700

    Fix restarting cinder HA services on config change

    Specify the tripleo_ha_wrapper ansible role use a separate marker
    file to detect when it should restart the cinder-backup and
    cinder-volume services. This ensures both services get restarted
    when the config changes. Unless a separate marker file is used
    for each service, only the first one (cinder-backup) gets
    restarted.

    Closes-Bug: #1981591
    Change-Id: Ib5c06ab5169942ddaf56a46ad7f14e9497b7e550
    (cherry picked from commit 7d76af34f54aa159b0e52d132705659be69b23a1)
    (cherry picked from commit 77d0ca4448599e6016c91361a050e7832cc9f970)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 17.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.