With scaling enabled right-positioned panel overlaps maximized windows

Bug #1981199 reported by Pilosa
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
budgie-desktop (Ubuntu)
Fix Released
Medium
fossfreedom
Jammy
Fix Released
Medium
fossfreedom
Kinetic
Fix Released
Medium
fossfreedom

Bug Description

[ Impact ]

 * If the panel is positioned on the right side it overlaps maximized windows when scaling is 200%. The error also occurs with fractional scaling.

 * This is a usability issue for any user who uses right-aligned panels (for example RTL users such as arabic may use right-aligned panels as opposed to left-aligned panels for 'roman' based languages and locales).

 * There is no impact on kinetic users since the fix is already included in the kinetic budgie-desktop version.

[ Test Plan ]

 * Using budgie-desktop-settings create a panel and align it to the right-side.
 * logout and login
 * open an application and maximise the application. Note that the right-side window controls are visible and accessible i.e. not behind the right aligned panel.
 * From a regression testing point of view - move the newly created panel to each of the two other sides of the screen not occupied.
 * repeat the open application and maximise app test and note that the window contents are NOT obscured / hidden by the moved panel.
 * move the panel back to the right-side of the screen

 * Using budgie-control-center set scaling to be either 100% or use any fractional scaling value
 * logout and login
 * open an application and maximise the application. Note that the right side window controls are now obscured/hidden behind the right aligned panel

 * from the proposed repo install the following packages:

   sudo apt update
   sudo apt install budgie-desktop budgie-core libbudgie-plugin0 libbudgie-private0 libbudgietheme0 libraven0 gir1.2-budgie-1.0

 * Logout and login
 * open an application and maximise the application. Note that the right-side window controls are visible and accessible i.e. not behind the right aligned panel.
 * Using budgie-control-center set scaling to 100% i.e. no fractional scaling
 * logout and login
 * open an application and maximise the application. Note that the right-side window controls are visible and accessible i.e. not behind the right aligned panel.

 * From a regression testing point of view - move the newly created panel to each of the two other sides of the screen not occupied.
 * repeat the open application and maximise app test and note that the window contents are NOT obscured / hidden by the moved panel.

[ Where problems could occur ]

 * The change is specifically around the way panels and its dimensions are calculated for creating Xorg struts. Regressions would be expected to be immediately visible when panels are on different edges and an application is maximised on the screen.

 * The UB team has tested this and have confirmed that the upstream fix has not introduced regressions https://github.com/BuddiesOfBudgie/budgie-desktop/issues/145
 * The test plan includes testing the regression possibilities by examining panels on all sides of the screen.

[ Other Info ]

 * N/A

----

If the panel is positioned on the right side it overlaps maximized windows when scaling is 200%. The error also occurs with fractional scaling.

Budgie version = budgie-desktop 10.6.1
Operating system = Ubuntu Budgie 22.04

Steps to reproduce the issue:

* Fresh Ubuntu Budgie Installation
* Budgie Desktop Settings: Move given panel to the right
* Budgie Control Center: Apply scaling 200% (or any fractional scaling)
* Maximize any application window

The maximized window takes the full screen width and is overlapped by the panel.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: budgie-desktop 10.6.1-1ubuntu1~22.04
ProcVersionSignature: Ubuntu 5.15.0-40.43-generic 5.15.35
Uname: Linux 5.15.0-40-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.1
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: Budgie:GNOME
Date: Mon Jul 11 10:49:10 2022
InstallationDate: Installed on 2022-04-27 (74 days ago)
InstallationMedia: Ubuntu-Budgie 22.04 LTS "Jammy Jellyfish" - Release amd64 (20220419)
PackageArchitecture: all
SourcePackage: budgie-desktop
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Pilosa (pilosa) wrote :
Revision history for this message
fossfreedom (fossfreedom) wrote :

Fixed upstream via this commit https://github.com/BuddiesOfBudgie/budgie-desktop/commit/80696102cfc36b9da9b448dbc7d0d602010dbcb9

Fix is narrow in scope, can be tested easily and is unlikely to cause additional issues.

Candidate for a SRU.

Changed in budgie-desktop (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → fossfreedom (fossfreedom)
Changed in budgie-desktop (Ubuntu Jammy):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → fossfreedom (fossfreedom)
no longer affects: budgie-desktop (Ubuntu Jammy)
Changed in budgie-desktop (Ubuntu):
status: Triaged → In Progress
description: updated
description: updated
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

is this fixed in kinetic?

Revision history for this message
fossfreedom (fossfreedom) wrote :

@tjaalton - yes this is fixed in kinetic

Changed in budgie-desktop (Ubuntu Kinetic):
status: In Progress → Fix Released
Changed in budgie-desktop (Ubuntu Jammy):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → fossfreedom (fossfreedom)
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Pilosa, or anyone else affected,

Accepted budgie-desktop into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/budgie-desktop/10.6.1-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in budgie-desktop (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
fossfreedom (fossfreedom) wrote :

budgie-desktop/10.6.1-1ubuntu2
budgie-core/10.6.1-1ubuntu2
ibbudgie-plugin0/10.6.1-1ubuntu2
libbudgie-private0/10.6.1-1ubuntu2
ibbudgietheme0/10.6.1-1ubuntu2
ibraven0/10.6.1-1ubuntu2
gir1.2-budgie-1.0/10.6.1-1ubuntu2

Tested as per test case - results passed i.e. window no longer overlaps right panel with fractional scaling enabled. Regression tested with and without fractional scaling with panels in other positions.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package budgie-desktop - 10.6.1-1ubuntu2

---------------
budgie-desktop (10.6.1-1ubuntu2) jammy; urgency=medium

  * Bug-fix
    - selected keyboard layout not applied after reboot
      ibus-keyboard-handling.patch (LP: #1956240)
    - statusbar icons moving around and changing order after reboot
      Rewrite-initial-applet-layoute.patch (LP: #1990642)
    - With scaling enabled, right-positioned panel overlaps maximized windows
      Fix-math-for-calculating-right-panel-strut.patch (LP: #1981199)

 -- David Mohammed <email address hidden> Sun, 09 Oct 2022 13:55:14 +0100

Changed in budgie-desktop (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for budgie-desktop has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.