Ceph public/cluster networks should not be updated during overcloud deploy

[John Fulton]

If you deploy ceph like this:

openstack overcloud ceph deploy \
-o /home/stack/templates/overcloud-ceph-deployed.yaml \
--container-image-prepare "/home/stack/containers-prepare-parameter.yaml" \
 --config /home/stack/initial-ceph.conf ...

Where initial-ceph.conf contains the following:

 [global]
 public_network = '172.120.3.0/24,172.117.3.0/24,172.118.3.0/24,172.119.3.0/24'
 cluster_network = '172.120.4.0/24,172.117.4.0/24,172.118.4.0/24,172.119.4.0/24'
 ms_bind_ipv4 = true
 ms_bind_ipv6 = false

Then the ceph networks are configured correctly. However, if you then deploy the overcloud it will update the Ceph public/cluster networks with data from Heat which might not be correct as the initial-ceph.conf is not excepted to be passed to the overcloud deployment.

This change is not sufficient because deployed_ceph should be true during the initial overcloud deployment:

https://review.opendev.org/c/openstack/tripleo-ansible/+/846950/1/tripleo_ansible/roles/tripleo_cephadm/tasks/cephadm_config_set.yaml#27

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/849048

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/849083

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/849048
Committed: https://opendev.org/openstack/tripleo-ansible/commit/70bbaf6b81074256cfa20c2698c2ae87d76d95cf
Submitter: "Zuul (22348)"
Branch: master

commit 70bbaf6b81074256cfa20c2698c2ae87d76d95cf
Author: John Fulton <email address hidden>
Date: Thu Jul 7 17:59:04 2022 -0400

    Only run Ceph network_config_set during initial deployment

    There is no reason to include the network_config_set tasks
    file in the cephadm_config_set tasks which can be run both
    before and during overcloud deployment. It is safer to only
    run it during the initial Ceph deployment. The danger is that
    the network_config_set tasks file from the tripleo_cephadm
    role can misconfigure Ceph during overcloud deployment if
    the Ceph deployment relied on an initial ceph.conf to
    configure the Ceph networks.

    Change-Id: I74e1197362517c3ad4bbdfc54adbf3ac934acf4b
    Closes-Bug: #1980992

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/849083
Committed: https://opendev.org/openstack/tripleo-ansible/commit/69d373547df71c422c181eb2efb9a5ab445057c7
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 69d373547df71c422c181eb2efb9a5ab445057c7
Author: John Fulton <email address hidden>
Date: Thu Jul 7 17:59:04 2022 -0400

    Only run Ceph network_config_set during initial deployment

    There is no reason to include the network_config_set tasks
    file in the cephadm_config_set tasks which can be run both
    before and during overcloud deployment. It is safer to only
    run it during the initial Ceph deployment. The danger is that
    the network_config_set tasks file from the tripleo_cephadm
    role can misconfigure Ceph during overcloud deployment if
    the Ceph deployment relied on an initial ceph.conf to
    configure the Ceph networks.

    Change-Id: I74e1197362517c3ad4bbdfc54adbf3ac934acf4b
    Closes-Bug: #1980992
    (cherry picked from commit 70bbaf6b81074256cfa20c2698c2ae87d76d95cf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 5.0.0 release.