novnc not working after upgrading to Yoga

[Alok Prudhvi]

Description
===========

After upgrading the platform to Yoga release i was not able to access the novnc console and below are the error logs i see in nova-novncproxy.log. Further verified the Yoga release notes and found that the below two parameters were completely remove. I've also unset the console-access-protocol and set it back to novnc to see if there might be any change in the vnc config option but nothing has changed.
Release notes:
vnc-related config options were deprecated in Pike release and now has been removed:

vncserver_listen opt removed, now we use only server_listen to bind vnc address opt.

vncserver_proxyclient_address opt removed, now we use only server_proxyclient_address opt.

Error log:
2022-07-04 06:44:21.899 919814 INFO nova.compute.rpcapi [req-b35bd8d9-d7ad-443f-896c-9c58e63e6e2c - - - - -] Automatically selected compute RPC version 6.0 from minimum service version 61
2022-07-04 06:44:21.940 919814 INFO nova.console.websocketproxy [req-b35bd8d9-d7ad-443f-896c-9c58e63e6e2c - - - - -] 109: connect info: ConsoleAuthToken(access_url_base='https://10.222.88.154:6080/vnc_auto.html',console_type='novnc',created_at=2022-07-04T06:37:38Z,host='127.0.0.1',id=743,instance_uuid=b045037a-6b5a-4d0f-a1f9-589cfa7e76de,internal_access_path=None,port=5912,token='***',updated_at=None)
2022-07-04 06:44:21.942 919814 INFO nova.console.websocketproxy [req-b35bd8d9-d7ad-443f-896c-9c58e63e6e2c - - - - -] 109: connecting to: 127.0.0.1:5912

Even after upgrading the nova cloud controller charm to latest revision the option in nova.conf remains as vncserver_listen and vncserver_proxyclient they were not being changed to server_listen and server_proxyclient.
Did any one face similar issue with novnc on Yoga.
Charm revision - 601

[Nadine Zander (nadinezan)]

We can confirm the issue on yoga.

We temporarily fixed the issue by adding a section into nova.conf
[vnc]
server_listen = ipaddress
server_proxyclient_address = ipaddress

restarting nova services and testing it by rebooting the instance on the node.

[Alok Prudhvi (alokprudhvi)]

Thanks for the reply. But if we make any manual configuration to the files they get over written when a new change happens to the application right? Is there any other alternative approach for this?

[Alex Kavanagh (ajkavanagh)]

This seems like a change is required/to be investigated in the templates for setting a [vnc] section with the appropriate values.

Needs backport to stable/yoga branch as well.

[Felipe Reyes (freyes)]

This commit created the [vnc] section http://opendev.org/openstack/nova/commit/11a42d40306f56105447a32cc521bb44f6678b59 , and the backwards compatibility support was effectively dropped in yoga - https://opendev.org/openstack/nova/commit/cec9e7f1f13f62ff813df32d70d6455917398868

[Alok Prudhvi (alokprudhvi)]

What should we do to get this change in place for our upgraded platform? Do we have to set the console-access-protocol back to novnc and it should take the new changes that were applied?

[Jamie Simmonds (jsimmondskm)]

Within our environment we have cloned nova-compute, applied the fix (created templates/yoga/nova.conf from templates/train/nova.conf) and moved the vnc options from the [default] section to a new [vnc] section.

Built this locally with charmcraft and switched the application out with juju refresh.

Not sure if this is the correct way to locally patch issues like this while waiting for a fix?

[Alok Prudhvi (alokprudhvi)]

Hi after modifying the vnc config from [default] to [vnc] and restarting the nova-compute service oall the compute hosts and failed with below error messages.
FYI - i'm changing these configurations on nova-compute not nova-cloud-controller. Attached screenshot with logs.

[Felipe Reyes (freyes)]

this seems to be an occurrence of bug 1974082 which was already fixed and backported, I'm marking it as invalid, but if new evidence suggest this is not correct please reopen.