update_floatingip SQL execution without transaction in progress

[Lajos Katona]

With Opensearch some "SQL execution without transaction in progress" warnings (and traceback after it) are visbile:

https://opensearch.logs.openstack.org/_dashboards/app/discover/?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-7d,to:now))&_a=(columns:!(build_name),filters:!(),index:'94869730-aea8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:'message:%22ORM%20session:%20SQL%20execution%20without%20transaction%20in%20progress%22'),sort:!())

The method update_floatingip is missing db context by the traceback (see [1] for example)

[1]: https://51a92479c3d8f1409d9a-2c72582c36065b074be978cdc62a0003.ssl.cf2.rackcdn.com/841838/11/check/neutron-ovs-tempest-dvr-ha-multinode-full/7d637f4/controller/logs/screen-q-svc.txt

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/848701

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/848701
Committed: https://opendev.org/openstack/neutron/commit/31a15fdd6d7b52415ca250a63b31bf841564e92a
Submitter: "Zuul (22348)"
Branch: master

commit 31a15fdd6d7b52415ca250a63b31bf841564e92a
Author: elajkat <email address hidden>
Date: Tue Jul 5 09:57:54 2022 +0200

    [sqlalchemy-20] Remove retry decorator from update_floatingip_status

    L3_NAT_dbonly_mixin.update_floatingip_status is called from methods
    which are decoarted with retry decorator or from within a db context.
    As update_floatingip_status also called from OVNL3RouterPlugin added a
    utility method, update_floatingip_status_retry with decorator to avoid
    retrying OVN methods, and added CONTEXT_WRITER here also as other calls
    of update_floatingip_status from l3_rpc for example uses CONTEXT_WRITER.

    Change-Id: Ifdb008c2402aa24766cbd30dd53458599076c955
    Closes-Bug: #1980721

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.