crypto: hisilicon/qm - modify 'QM_RESETTING' clearing error

[Fred Kimmy]

[Bug Description]

ACC driver enable vf function for Ubuntu20.04.4 release, after vf reset, it fail to run "rmmod hisi_zip"

[Steps to Reproduce]

1)modprobe hisi_zip ,

2)echo 1 > /sys/devices/pci0000:74/0000:74:00.0/0000:75:00.1/reset

3)rmmod hisi_zip

[Actual Results]

fail

[Expected Results]

ok

[Reproducibility]

100%

[Additional information]

(Firmware version, kernel version, affected hardware, etc. if required):

[Resolution]

crypto: hisilicon/qm - modify 'QM_RESETTING' clearing error

(https://patchwork.kernel.org/project<email address hidden>/)

[Ike Panhc (ikepanhc)]

Patch looks good to me but it has not yet hit mainline. I will proceed when it is merged into mainline kernel.

[Ike Panhc (ikepanhc)]

Already hit mainline

$ git show 3121f021c00ae
commit 3121f021c00aeed599d6f5d1c737b1bc8e6a05d8
Author: Weili Qian <email address hidden>
Date: Sat May 15 18:44:38 2021 +0800

    crypto: hisilicon/qm - modify 'QM_RESETTING' clearing error

    Before device reset, the driver sets 'QM_RESETTING' flag, but after reset,
    the wrong flag is cleared. This patch modifies the problem of inconsistent
    flags.

    Signed-off-by: Weili Qian <email address hidden>
    Signed-off-by: Herbert Xu <email address hidden>

[Ike Panhc (ikepanhc)]

I can rmmod hisi_zip after reset zip engine with 5.15 Ubuntu kernel. Is there something missing?

ubuntu@kreiken:~$ sudo dmesg -C
ubuntu@kreiken:~$ sudo modprobe hisi_zip
ubuntu@kreiken:~$ lsmod | grep zip
hisi_zip 36864 0
hisi_qm 98304 3 hisi_sec2,hisi_zip,hisi_hpre
uacce 20480 4 hisi_sec2,hisi_qm,hisi_zip,hisi_hpre
ubuntu@kreiken:~$ echo 1 | sudo tee /sys/devices/pci0000:74/0000:74:00.0/0000:75:00.0/reset
1
ubuntu@kreiken:~$ sudo rmmod hisi_zip
ubuntu@kreiken:~$ dmesg
[ 6143.862702] ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit
[ 6143.873712] ACPI: IORT: [Firmware Bug]: Root complex missing memory address limit
[ 6158.490149] hisi_zip 0000:75:00.0: FLR resetting...
[ 6158.597774] hisi_zip 0000:75:00.0: FLR reset complete
ubuntu@kreiken:~$ uname -a
Linux kreiken 5.15.0-41-generic #44~20.04.1-Ubuntu SMP Sat Jun 25 06:34:19 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

[Ike Panhc (ikepanhc)]

Checked changelog and the patch has been applied to Ubuntu 5.15 kernel for a while. Set to fix released.