Delete Files: move files to trash instead of deleting instantly

[Stefan Franz]

Linux Mint 20.3 Cinnamon

After rightclick in the browser list / delete track files from list
1. The track is deleted without trash (is it possible to send it to the trash?)
2. A small window appears that 1 song is removed from the database - but the windows does not close itsself.

[Stefan Franz (stefan-franz)]

hmmm....now, after deleting 3 files more the windows close istsself....
I report if the error comes again.

[ronso0 (ronso0)]

The "N track files were removed" dialog is not supposed to close itself.
Are you saying the dialog pops up, and while you do nothing (no button on keyboard or controller pressed, no mouse click), it is closed magically?

Note that controller with a Browse or Trax push/rotary encoder have [Library],GoToItem mapped. Per context this will trigger different actions, see https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[Library]-GoToItem, e.g. in dialogs it can press buttons.

[ronso0 (ronso0)]

1. The track is deleted without trash (is it possible to send it to the trash?)

Yes, this is noted as TODO.
It's just someone needs to implement it :)

[ronso0 (ronso0)]

QFile::moveToTrash is only supported in Qt 5.15 and newer.

IIRC (someone correct me if I'm wrong) we wait for the first point release of the current Ubuntu LTS (22.04.1) in order to drop support for Ubuntu 20.04 which is the only operating system that requires supporting Qt 5.12, and use Qt 5.15+
https://wiki.ubuntu.com/Releases#Future

We could as well add it now with Qt version switches, but then we wouldn't have a consistent implementation on all supported OS :|

[Stefan Franz (stefan-franz)]

The small window in the front comes not always if i delete a track. If it comes, it stands as here on the screenshot and the progress bar does not work.
The cancel Button works and the file is deletet from the database. I think only the gui does sometimes not wirk right - the database correction works.

[ronso0 (ronso0)]

I thought you were referring to the Success dialog

To clarify, the workflow has multiple dialogs:

0) if you open the menu from a deck and click Delete while the track is
   still being played, Mixxx will ask you to stop the deck first
1) confirmation "Permanently delete these files from disk?"
2) progress dialog, only shown if required. quoted from source code:
 /// This dialog
 /// only appears if processing takes longer than the given grace
 /// period. This avoids that an open context menu gets closed
 /// while processing only a few tracks.
3) Success: "Track File(s) Deleted"
4) Failure report if file(s) could not be deleted

[ronso0 (ronso0)]

I hope you didn't discover any other issues with the workflow.

This bug now only covers moveToTrash. Please file a separate report for dialog issues so we can track those independently.
Thank you for testing btw!

[Daniel Schürmann (daschuer)]

The limiting OS is macOs
It required Qt 5.12 because of the waveforms.
This will only be solved if one writes new waveforms, so we are not talking about a few month to wait.

It feels bad to hold this useful feature back for all users just for sake of consistent behavior.
I would welcome a solution with a version guard.

[Stefan Franz (stefan-franz)]

Linux Mint 20.3 Cinnamon - Mixxx 2.4 alpha2 - 1225
Deleting Files works now without an hanging window as - point 2 of my original report.

[ronso0 (ronso0)]

yes, that was a separate bug resolved by https://github.com/mixxxdj/mixxx/pull/4831

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10760