ubuntu 20.04.4 fail to ping for HNS

[Fred Kimmy]

[Bug Description]
the electrical port cannot be pinged if repeatedly rmmod or insmod hns* ko . Communication fails to be restored when the electrical port is Down and Up repeatedly.

[Steps to Reproduce]
1)rmmod hns3
2)modprobe hns3
3)ping <the electrical port ip>

[Actual Results]
Some electrical ports cannot be pinged.

[Expected Results]
All ports can be pinged.

[Reproducibility]
High probability

[Additional information]
(Firmware version, kernel version, affected hardware, etc. if required2022060604455):
kernel version Linux ubuntu 5.13.0-30-generic #33~20.04.1-Ubuntu SMP Mon Feb 7 14:28:43 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

[Resolution]
net: phy: realtek: enable ALDPS to save power for RTL8211F
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=66e22932eb795f12cc78c7592581673049d85a8c)
net: phy: realtek: add dt property to enable ALDPS mode
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d90db36a9e748c9d886df15f5e17b341f0e5bcd5)

[Ike Panhc (ikepanhc)]

The patches describe new function "Advanced Link Down Power Saving" and it does not mention link failure in comment.

Is this the right patch to solve ping issue?

[Fred Kimmy (kongzizaixian)]

=>Is this the right patch to solve ping issue?
this first patch enable LDPS mode for phy and change phy clock behavier, so the second patch will fix this issue.

[Ike Panhc (ikepanhc)]

That sounds we need to apply 1st patch for reproducing this issue. Since we do not have both patches, this issue shall not be reproduce-able.

I will try to reproduce this issue on 5.4 and 5.15 Ubuntu kernels. If can not, I will close this bug.

[Ike Panhc (ikepanhc)]

I try these commands:

  for i in `seq 1 10`; do echo === $i ===;sudo rmmod hns3;sudo modprobe hns3;sleep 3;ping -c 1 10.228.68.139; done

All 10 pings success.

Is that possible that it takes few seconds for network manager setting IP for ports?

[Ike Panhc (ikepanhc)]

Checked Ubuntu 5.15 kernel changelog and they have been merged since 5.11 HWE kernel.