tls_insecure_skip_verify is most likely no longer needed

[Andrea Ieri]

src/templates/vault.hcl.j2 contains the following lines:

  # Use tls_insecure_skip_verify due to https://github.com/hashicorp/vault/issues/4961
  # tls_insecure_skip_verify is currently only supported in the snap version of vault.
  tls_insecure_skip_verify = "true"

Issue 4961[0] has been fixed with PR 8037[1], which landed in vault 1.4.0 (April 7th, 2020).

It should be pretty safe to drop the config option since I don't see any charm channel for versions older than 1.5

[0] https://github.com/hashicorp/vault/issues/4961
[1] https://github.com/hashicorp/vault/pull/8037

[Alex Kavanagh (ajkavanagh)]

Agreed; it can probably be dropped.

[Phan Trung Thanh (tphan025)]

Hello, I see this line is still present is the master branch so I'd like to help working on it, I'm assigning it to myself but I want to check if it's already being worked on?

Thanks!

[Alex Kavanagh (ajkavanagh)]

Hi @tphan025, you are the only one working on it. Looking forward to the fix. If you have any issues then please reach out to the OpenStack team on IRC OFTC #openstack-charms of in the charmhub mattermost channel: https://chat.charmhub.io/charmhub/channels/openstack-charms. Thanks.

[Phan Trung Thanh (tphan025)]

Hi, @ajkavanagh, thanks for the info.

I have submitted a PR here : https://review.opendev.org/c/openstack/charm-vault/+/897001?tab=comments

Can you take a look and let me know if the changes look ok to you?

Thanks!
Thanh