ceph deploy fails due to extra slash in container path

[John Fulton]

Description of problem: Overcloud deploy is attempted using a satellite for content. It fails deploying ceph at task: Run cephadm bootstrap

The error occurs executing this command because it returns: Error: invalid reference format:

/bin/podman pull undercloud1702-0.ctlplane.redhat.local:8787//default_organization-ceph4_6_containers-rhceph:5-170
Error: invalid reference format

There is an extra slash in that command between 8787 and default_organization.

This is seen when looking at container images (i.e. the second slash is not there):

openstack tripleo container image list | grep 5-170
/usr/lib/python3.9/site-packages/ansible/_vendor/__init__.py:42: UserWarning: One or more Python packages bundled by this ansible-core distribution were already loaded (pyparsing). This may result in undefined behavior.
  warnings.warn('One or more Python packages bundled by this ansible-core distribution were already '
| docker://undercloud1702-0.ctlplane.redhat.local:8787/default_organization-ceph4_6_containers-rhceph:5-170

Now try the podman pull without the second slash:

/bin/podman pull undercloud1702-0.ctlplane.redhat.local:8787/default_organization-ceph4_6_containers-rhceph:5-170
Trying to pull undercloud1702-0.ctlplane.redhat.local:8787/default_organization-ceph4_6_containers-rhceph:5-170...
Getting image source signatures
Copying blob 4eef1fa1f1c1 done
Copying blob 967da9d9d3cf done
Copying blob eb24191cef20 done
Copying config 9ea8ac4eae done
Writing manifest to image destination
Storing signatures
9ea8ac4eae90914d5ea5096dbcf010fc393ce90c3daa94385fc2b017de0629b1

Version-Release number of selected component (if applicable): RHOS-17.0-RHEL-9-20220615.n.2

How reproducible: Every time

Steps to Reproduce:
1. Do an overcloud deploy from a satellite server. The error is seen when the sh script overcloud_ceph_deploy.sh is executed.
2.
3.

Actual results: ceph fails to deploy with error above

Expected results: ceph deploys successfully

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/847209

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/847209
Committed: https://opendev.org/openstack/python-tripleoclient/commit/c9218859a2611923f809cd7650db26370f421019
Submitter: "Zuul (22348)"
Branch: master

commit c9218859a2611923f809cd7650db26370f421019
Author: John Fulton <email address hidden>
Date: Wed Jun 22 13:17:58 2022 -0400

    Do not end ceph_namespace with a slash

    The parse_container_image_prepare utility function
    incorrectly appends a slash to the ceph_namespace tag
    it extracts from the container image prepare file. Use
    not '/'.join but os.path.normpath of os.path.join.

    Change-Id: I47e55b33ae70e1a6de141bf96c0080b730dc2966
    Closes-Bug: #1979554

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/847433

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/847433
Committed: https://opendev.org/openstack/python-tripleoclient/commit/c0b144709306ad5763ef91e415409c3db9a1d40a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c0b144709306ad5763ef91e415409c3db9a1d40a
Author: John Fulton <email address hidden>
Date: Wed Jun 22 13:17:58 2022 -0400

    Do not end ceph_namespace with a slash

    The parse_container_image_prepare utility function
    incorrectly appends a slash to the ceph_namespace tag
    it extracts from the container image prepare file. Use
    not '/'.join but os.path.normpath of os.path.join.

    Change-Id: I47e55b33ae70e1a6de141bf96c0080b730dc2966
    Closes-Bug: #1979554
    (cherry picked from commit c9218859a2611923f809cd7650db26370f421019)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 19.0.0 release.