Deprecate SOAP support

Bug #1979373 reported by Gold
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Robert Lyon

Bug Description

While working through PHPStan issues I found that the SOAP implementation should have been reliably throwing errors. The lack of issues in this area suggests that this is not being used at all.

Rather than supporting what is now quite old code we should just deprecate it and remove it from the codebase.

The area that drew this to my attention is here:

https://git.mahara.org/mahara/mahara/-/blob/main/htdocs/lib/mahara.php#L2640

$wsseSoapClient = new webservice_soap_client_wsse(
  array($client, '_doRequest'),
  $client->wsdlfile,
  $client->getOptions()
);

The first parameter, which should declare our request, is unused in webservice_soap_client_wsse()
The third parameter is unused also. In the webservice_soap_client_wsse() class there is a private $options, but this is never set.

Also, webservice_soap_client(), which gives us $client, has no getOptions() method so this should also be erroring out loudly.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.10.0
importance: Undecided → Wishlist
status: New → Confirmed
Changed in mahara:
milestone: 22.10.0 → 23.04.0
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

In the first instance: Add deprecation message that it will go away in 24.04.

Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review
Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.