SRU pygobject 3.42.1, including fix for the append function

Bug #1979347 reported by Fred
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pygobject (Ubuntu)
Fix Released
High
Unassigned
Jammy
Fix Released
High
Nathan Teodosio

Bug Description

>> Impact <<

Applications crash when they call the append function to append data to stores.

>> Test plan <<

When executing the attached bug.py script,

- With the fix: A dummy window with a text field is mapped.

- Without the fix: An error message is raised and no window is mapped.

>> Regression potential <<

Since this includes a new upstream release, by looking at the NEWS file <https://gitlab.gnome.org/GNOME/pygobject/-/blob/master/NEWS>, regressions could show up:

- On programs which use ListStore and Treeview. Additionally, those changes should not affect GTK2 or GTK3.

- As leaks, given the replace of g_error by g_critical by <https://gitlab.gnome.org/GNOME/pygobject/-/merge_requests/179>.

Revision history for this message
Fred (eldmannen+launchpad) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, could you provide a code example which could be used as testcase for a stable update?

Changed in pygobject (Ubuntu):
importance: Undecided → High
status: New → Incomplete
Revision history for this message
Fred (eldmannen+launchpad) wrote :

Yes, it is.

model = Gtk.ListStore(str)
model.append(['example'])

A file is attached.

Revision history for this message
Sebastien Bacher (seb128) wrote :

The issue is fixed in kinetic https://launchpad.net/ubuntu/+source/pygobject/3.42.1-1 but we should do a stable update there

summary: - Apps crash when append to store
+ SRU pygobject 3.42.1, including fix for the append function
Changed in pygobject (Ubuntu):
status: Incomplete → In Progress
Changed in pygobject (Ubuntu Jammy):
status: New → In Progress
assignee: nobody → Nathan Teodosio (nteodosio)
Jeremy Bícha (jbicha)
Changed in pygobject (Ubuntu):
status: In Progress → Fix Released
Changed in pygobject (Ubuntu Jammy):
importance: Undecided → High
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

I verified the bug on 3.42.0-3build1 on Jammy. This is an SRU for it, which I verified that builds with pbuilder and solves the bug in Jammy.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Nice work Nathan. I'm adding back the changelog entry from 3.42.0-3build1 and reverting the Standard-Versions change to lower the diff to review for the SRU team and uploading

Changed in pygobject (Ubuntu Jammy):
status: In Progress → Fix Committed
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote :

> Since this includes a new upstream release, by looking at the NEWS file
> <https://gitlab.gnome.org/GNOME/pygobject/-/blob/master/NEWS>,
> regressions could show up

This is not really an analysis of the risks of this SRU, which is what the SRU team expects to see here.

Also, a reminder to not set SRU bugs to 'fix committed' when uploaded to the queue. These are process bugs, and 'fix committed' is used only once the package is accepted into -proposed; until then it should remain 'in progress'. Thanks!

Changed in pygobject (Ubuntu Jammy):
status: Fix Committed → Incomplete
Steve Langasek (vorlon)
description: updated
Changed in pygobject (Ubuntu Jammy):
status: Incomplete → New
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Fred, or anyone else affected,

Accepted pygobject into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pygobject/3.42.1-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in pygobject (Ubuntu Jammy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Fred (eldmannen+launchpad) wrote :

Hi Steve,

I tested it from -proposed and can confirm that this resolves the issues that I've had.

Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (pygobject/3.42.1-0ubuntu1)

All autopkgtests for the newly accepted pygobject (3.42.1-0ubuntu1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.7.5-3 (armhf)
gexiv2/0.14.0-1build1 (armhf)
gnome-feeds/0.16.2+dfsg1-1 (armhf)
budgie-extras/1.4.0-1ubuntu2 (armhf)
aptdaemon/1.1.1+bzr982-0ubuntu39 (armhf)
dogtail/0.9.11-10 (armhf)
dasbus/1.6-2 (armhf)
apport/2.20.11-0ubuntu82.1 (amd64)
gvfs/1.48.2-0ubuntu1 (ppc64el)
bleachbit/4.4.2-1 (armhf)
goocalendar/0.7.2-1 (armhf)
freedombox/22.5 (armhf)
binoculars/0.0.10-1.1 (armhf)
evolution-data-server/3.44.2-0ubuntu1 (armhf)
formiko/1.3.0-2 (armhf)
dbus-python/1.2.18-3build1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#pygobject

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Sebastien Bacher (seb128) wrote :

The failing autopkgtest worked after a retry and were mostly due to builder issues

The one error remaining is fwupd which fails on
 libudev-dev : Depends: libudev1 (= 249.11-0ubuntu3) but 249.11-0ubuntu3.3 is to be installed

which isn't due to pygobject update

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I also verified the fix. Before I installed python3-gi 3.42.1-0ubuntu1, when I ran the script, I only got errors on the command line. After installing the update, the window showed and there were no errors on the command line.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pygobject - 3.42.1-0ubuntu1

---------------
pygobject (3.42.1-0ubuntu1) jammy; urgency=medium

  [ Jeremy Bicha ]
  * New upstream release (fixes LP: #1979347)
  * Drop python3.10 patch: applied in new release

 -- Nathan Pratta Teodosio <email address hidden> Thu, 23 Jun 2022 12:56:55 -0300

Changed in pygobject (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for pygobject has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.