KeyTable doesn't support %

Bug #1978933 reported by Mika Tiainen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dkimpy-milter
Fix Released
Medium
Scott Kitterman

Bug Description

Hi,

I am setting up dkimpy-milter and tried using % in KeyTable to have single entry used for multiple domains as documented:

If the first value consists solely of a percent sign ("%") character, it will be replaced by the apparent domain of the sender when generating a signature.

This doesn't seem to be supported. dkimpy-milter tries to match domain with %:

dkimpy-milter[30250]: self.domain: ['example.com'], self.fdomain: %, self.iequals: None

And skips signing as they don't match.

Attached patch fixes this for my simple test setup, but not sure if it is the correct way to handle this.

Revision history for this message
Mika Tiainen (mikat-cuuma) wrote :
Revision history for this message
Scott Kitterman (kitterman) wrote :

Seems reasonable. We'll give it a try. Thanks.

Changed in dkimpy-milter:
assignee: nobody → Scott Kitterman (kitterman)
importance: Undecided → Medium
milestone: none → 1.2.3
status: New → Fix Committed
Changed in dkimpy-milter:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.