The CinderScExcludedDomainIp parameter has no effect

[Takashi Kajinami]

Description
===========
The CinderScExcludedDomainIp parameter defined in deployment/cinder/cinder-backend-dellemc-sc-puppet.yaml is not used and has no effect, while the CinderScExcludedDomainIps parameter is actually used.

We should make it override the CinderScExcludedDomainIps parameter or at least deprecate it so that we can remove that unused parameter in a future release.

[Takashi Kajinami (kajinamit)]

> We should make it override the CinderScExcludedDomainIps parameter
Might be a better idea to give priority to Ips, instead of Ip.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847739

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ronelle Landy <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847739
Reason: will reset the gate

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847739
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/95a02d2419fa279838a5bc3b600b235f41615cac
Submitter: "Zuul (22348)"
Branch: master

commit 95a02d2419fa279838a5bc3b600b235f41615cac
Author: katarimanoj <email address hidden>
Date: Tue Jun 28 19:59:09 2022 +0530

    Fix Cinder Dell EMC SC backend template

    The 'CinderSCStorageProtocol' parameter defined in
    cinder-backend-dellemc-sc-puppet.yaml is not used and
    has no effect. Modified it as 'CinderScStorageProtocol'
    similar to other parameters.

    The parameter 'CinderScExcludedDomainIp' is introduced
    when the backend support was added in the patch
    https://review.opendev.org/c/openstack/tripleo-heat-templates/+/727283
    but it is never used.
    Removed it as the 'CinderScExcludedDomainIps' parameter is already used.

    Closes-Bug: #1978749
    Closes-Bug: #1978750
    Change-Id: I6a82a542855e32bd82c67f34138271b060df5de2

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 17.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/891278

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/891278
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/0cf9c98ab9524e4eca517470ca6118085531fa4a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 0cf9c98ab9524e4eca517470ca6118085531fa4a
Author: katarimanoj <email address hidden>
Date: Tue Jun 28 19:59:09 2022 +0530

    Fix Cinder Dell EMC SC backend template

    The 'CinderSCStorageProtocol' parameter defined in
    cinder-backend-dellemc-sc-puppet.yaml is not used and
    has no effect. Modified it as 'CinderScStorageProtocol'
    similar to other parameters.

    The parameter 'CinderScExcludedDomainIp' is introduced
    when the backend support was added in the patch
    https://review.opendev.org/c/openstack/tripleo-heat-templates/+/727283
    but it is never used.
    Removed it as the 'CinderScExcludedDomainIps' parameter is already used.

    Closes-Bug: #1978749
    Closes-Bug: #1978750
    Change-Id: I6a82a542855e32bd82c67f34138271b060df5de2
    (cherry picked from commit 95a02d2419fa279838a5bc3b600b235f41615cac)