"hostname" option is required if the baremetal node name includes capital letters

[Harald Jensås]

When using baremetal deployment definition without hostname, but node name with uppercase letters:

- name: Controller
  count: 1
  instances:
    - name: Controller
- name: Compute
  count: 1
  instances:
    - name: Compute

The node provisioning process creates file:
 overcloud-deploy/overcloud/inventory-network-config.yaml

This file is is used when generating the ansible inventory. This file contain the hostnames with uppercase:

Compute:
  hosts:
    Compute:
      < .. config .. >
Controller:
  hosts:
    Controller:
      < .. config .. >

In the code generating the ansible inventory the hostname is lowercase because it is derived from a neutron port `dns_name` property.
The `dns_name` property is always lowercase:

$ openstack port set --dns-name UPPERCASE 3a10d10d-95bd-4c71-b24b-7d858af1ddc1
$ openstack port show 3a10d10d-95bd-4c71-b24b-7d858af1ddc1 -c dns_name
+----------+-----------+
| Field | Value |
+----------+-----------+
| dns_name | uppercase |
+----------+-----------+

The code that extend the inventory based on the `inventory-network-config.yaml` does a lookup using the lowercase name, and finds no data. The result is that any settings defined in `inventory-network-config.yaml` is not included in the inventory.

Since the hostname in inventory is always lowercase, we can convert to lowercase always when generating the `inventory-network-config.yaml`[1].

[1]https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/modules/tripleo_generate_inventory_network_config.py#L229

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/845486

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/845486
Committed: https://opendev.org/openstack/tripleo-ansible/commit/0056c2b8970a3f6d6317edcdf2372ff32c29de85
Submitter: "Zuul (22348)"
Branch: master

commit 0056c2b8970a3f6d6317edcdf2372ff32c29de85
Author: Harald Jensås <email address hidden>
Date: Fri Jun 10 23:39:25 2022 +0200

    Use lowercase hostname in inventory network config

    The ansible inventory uses the neutron port dns_name as
    hostname. The `dns_name` in neutron is always lowercase.
    If a hostname with one or more capital letters are used in
    baremetal deployment YAML the data lookup from `inventory-
    network-config.yaml` does not succeed.

    This change fixes this issue by converting the hostname to
    lowercase when creating the content for `inventory-network-
    config.yaml`

    Closes-Bug: #1978356
    Change-Id: I1ee53976ecc63d206d9604c896b1bb59807ad9ff

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/845400

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/845400
Committed: https://opendev.org/openstack/tripleo-ansible/commit/77cd3b0701c773930a5f4cec18cca6bc6b563d8b
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 77cd3b0701c773930a5f4cec18cca6bc6b563d8b
Author: Harald Jensås <email address hidden>
Date: Fri Jun 10 23:39:25 2022 +0200

    Use lowercase hostname in inventory network config

    The ansible inventory uses the neutron port dns_name as
    hostname. The `dns_name` in neutron is always lowercase.
    If a hostname with one or more capital letters are used in
    baremetal deployment YAML the data lookup from `inventory-
    network-config.yaml` does not succeed.

    This change fixes this issue by converting the hostname to
    lowercase when creating the content for `inventory-network-
    config.yaml`

    Closes-Bug: #1978356
    Change-Id: I1ee53976ecc63d206d9604c896b1bb59807ad9ff
    (cherry picked from commit 0056c2b8970a3f6d6317edcdf2372ff32c29de85)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 5.0.0 release.