PHP 8 Compatibility: account

[Gold]

This is to track patchsets that will bring the codebase up to be compliant with PHP 8.1.

The initial run through will be on a top level directory basis. i.e. the directories below htdocs. It will focus on the results from the PHPStan and Phan static analysis tools.

This bug tracks files in the account directory.

Testing will require identifying, from the patchset, where the code is used and then verifying that that area of the site still works in both PHP 7.4 and PHP 8.1.

https://phpstan.org/
https://github.com/phan/phan

[Gold (gold.catalyst)]

PHPStan is reporting the following that I'm having trouble resolving.

 ------ ---------------------------------------------------------------------
  Line migrateinstitution.php
 ------ ---------------------------------------------------------------------
  125 Instantiated class SimpleSAML\Auth\Simple not found.
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
 ------ ---------------------------------------------------------------------

[Kristina Hoeppner (kris-hoeppner)]

Doris, is this still a problem?

[Doris Tam (doristam)]

This was before we moved over to Composer. This is not a problem because we can no longer test verify this problem. Any PHP 8.1 issues will have come up and gotten resolved in https://bugs.launchpad.net/mahara/+bug/2008956