grafana machine charm is not handling boolean config for ldap
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Grafana Charm |
Fix Released
|
High
|
Alvaro Uria |
Bug Description
Charm: grafana
Store: charmhub
Channel: stable
Revision: 56
Series: ubuntu/focal
https:/
I’m configuring grafana with a yaml like this to connect it to the company LDAP where I configure using a boolean value for start_tls (among other things):
cat grafana-config.yaml
grafana:
...
...
ldap_
I’m then configuring grafana:
juju config grafana --file grafana-config.yaml
It all seems to be OK, but, in the resulting config on the grafana/0 unit:
juju ssh grafana/0 sudo cat /etc/grafana/
[[servers]]
host = "example.com"
port = 363
start_tls = "False"
Which causes an error for grafana since “False” is a string, where the value should be a false (boolean)
juju ssh grafana/0 sudo tail /var/log/
logger=ldap t=2022-
logger=context traceID=
Clearly, this is an error which prevents me from deploying this with LDAP connection.
I’m following the docs from https:/
Related branches
- Peter Sabaini (community): Approve
- 🤖 prod-jenkaas-bootstack (community): Needs Fixing (continuous-integration)
- BootStack Reviewers: Pending requested
-
Diff: 156 lines (+68/-19)4 files modifiedsrc/templates/ldap.toml.j2 (+4/-2)
src/tests/functional/tests/test_grafana.py (+1/-1)
src/tests/unit/test_grafana.py (+16/-16)
src/tests/unit/test_templates.py (+47/-0)
Changed in charm-grafana: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Alvaro Uria (aluria) |
Changed in charm-grafana: | |
status: | Confirmed → In Progress |
tags: | added: bseng-131 |
Changed in charm-grafana: | |
status: | In Progress → Fix Committed |
Changed in charm-grafana: | |
milestone: | none → 21.10 |
milestone: | 21.10 → 22.10 |
Changed in charm-grafana: | |
status: | Fix Committed → Fix Released |
Changed in charm-grafana: | |
status: | Fix Released → Fix Committed |
Changed in charm-grafana: | |
status: | Fix Committed → Fix Released |