mlxbf_gige: increase MDIO polling rate
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-bluefield (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
David Thompson |
Bug Description
SRU Justification:
[Impact]
There is MDIO logic within the mlxbf_gige driver that currently
polls for completed transactions every 100us. This has been
reviewed and tested in the lab and found to be inefficient.
[Fix]
The fix is to modify the driver logic to increase the MDIO
polling rate to 5us. With this change the amount of
time spent waiting for the MDIO BUSY signal to de-assert
drops from ~100us to ~27us for each operation.
[Test Case]
The driver should function as before, specifically:
* driver probes successfully
* oob_net0 link comes up, as seen with "ifconfig -a"
* reset and power cycle testing toggle PHY hardware,
and oob_net0 link still comes up
[Regression Potential]
This change affects all MDIO transactions to the board-level
PHY device, and as such, could cause a regression with PHY
communications. However, this change has been heavily tested.
CVE References
Changed in linux-bluefield (Ubuntu Focal): | |
assignee: | nobody → David Thompson (dthompso-98) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in linux-bluefield (Ubuntu): | |
status: | New → Invalid |
Changed in linux-bluefield (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
This bug is awaiting verification that the linux-bluefield /5.4.0- 1037.40 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- focal' to 'verification- done-focal' . If the problem still exists, change the tag 'verification- needed- focal' to 'verification- failed- focal'.
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!