openstack tripleo deploy --networks-file should not require absolute path

[John Fulton]

A deployment with "openstack tripleo deploy --networks-file network_data.yaml ... " [1] resulted in the network_data.yaml being ignored. My rendered overcloud-resource-registry-puppet.yaml contained networks I didn't have in my network_data.yaml which are in the default like internal_api [2]. As a workaround, I used the absolute path to my network_data.yaml file it was used and not ignored and the deployment worked I expected. E.g. my overcloud-resource-registry-puppet.yaml used the ctlplane network [3] (I was only using one extra network in network_data [4]).

[1]
sudo openstack tripleo deploy \
     --templates ~/templates \
     --yes \
     --standalone-role Standalone \
     --local-ip=$IP/$NETMASK \
     --control-virtual-ip $VIP \
     -r ~/templates/roles/Standalone.yaml \
     -e ~/templates/environments/standalone/standalone-tripleo.yaml \
     -e ~/templates/environments/cephadm/cephadm.yaml \
     -e ~/containers-prepare-parameters.yaml \
     -e standalone_parameters.yaml \
     -e deployed_ceph.yaml \
     -e deployed_network_env.yaml \
     --networks-file network_data.yaml \
     --output-dir $HOME \

[2]
  ServiceNetMap:
    ApacheNetwork: internal_api
    NeutronTenantNetwork: tenant
    AodhApiNetwork: internal_api
    BarbicanApiNetwork: internal_api
    GnocchiApiNetwork: internal_api
    MongodbNetwork: internal_api
    CinderApiNetwork: internal_api
    CinderIscsiNetwork: storage
    GlanceApiNetwork: internal_api
    GlanceApiEdgeNetwork: internal_api
    IronicApiNetwork: ctlplane
    IronicNetwork: ctlplane
    IronicInspectorNetwork: ctlplane
    KeystoneAdminApiNetwork: internal_api
    KeystonePublicApiNetwork: internal_api
    ManilaApiNetwork: internal_api
    NeutronApiNetwork: internal_api
    OctaviaApiNetwork: internal_api
    HeatApiNetwork: internal_api
    HeatApiCfnNetwork: internal_api
    HeatApiCloudwatchNetwork: internal_api
    NovaApiNetwork: internal_api
    PlacementNetwork: internal_api
    NovaMetadataNetwork: internal_api
    NovaLibvirtNetwork: internal_api
    SwiftStorageNetwork: storage_mgmt
    SwiftProxyNetwork: storage
    HorizonNetwork: internal_api
    MemcachedNetwork: internal_api

[3]
 ServiceNetMap:
    ApacheNetwork: ctlplane
    NeutronTenantNetwork: ctlplane
    AodhApiNetwork: ctlplane
    BarbicanApiNetwork: ctlplane
    GnocchiApiNetwork: ctlplane
    MongodbNetwork: ctlplane
    CinderApiNetwork: ctlplane
    CinderIscsiNetwork: storage
    GlanceApiNetwork: ctlplane
    GlanceApiEdgeNetwork: ctlplane
    IronicApiNetwork: ctlplane
    IronicNetwork: ctlplane
    IronicInspectorNetwork: ctlplane
    KeystoneAdminApiNetwork: ctlplane
    KeystonePublicApiNetwork: ctlplane
    ManilaApiNetwork: ctlplane
    NeutronApiNetwork: ctlplane
    OctaviaApiNetwork: ctlplane
    HeatApiNetwork: ctlplane
    HeatApiCfnNetwork: ctlplane
    HeatApiCloudwatchNetwork: ctlplane
    NovaApiNetwork: ctlplane
    PlacementNetwork: ctlplane
    NovaMetadataNetwork: ctlplane
    NovaLibvirtNetwork: ctlplane
    SwiftStorageNetwork: ctlplane
    SwiftProxyNetwork: storage
    HorizonNetwork: ctlplane
    MemcachedNetwork: ctlplane

[4]
- name: Storage
  mtu: 1350
  vip: true
  name_lower: storage
  dns_domain: storage.mydomain.tld.
  service_net_map_replace: storage
  subnets:
    storage_subnet:
      ip_subnet: '192.168.42.0/24'
      allocation_pools: [{'start': '192.168.42.4', 'end': '192.168.42.250'}]