Improper matching/validation of mount-control

[Daniel Manrique]

The snap has this:

mntctl:
    interface: mount-control
    mount:
    - what: /dev/sd*
      where: /mnt/*
      type:
      - vfat
      options:
      - rw
      - sync
      - async
      persistent: false

The snap declaration json has this:

{
"mount-control": {
    "allow-auto-connection": {
      "on-store": [
        "honeywell-international-inc"
      ],
      "plug-attributes": {
        "mount": [
          {
            "options": [
              "rw",
              "sync",
              "async"
            ],
            "persistent": false,
            "type": [
              "vfat"
            ],
            "what": "/dev/sd\\*",
            "where": "/mnt/\\*"
          }
        ]
      }
    },
    "allow-installation": {
      "on-store": [
        "honeywell-international-inc"
      ],
      "plug-attributes": {
        "mount": [
          {
            "options": [
              "rw",
              "sync",
              "async"
            ],
            "persistent": "false",
            "type": [
              "vfat"
            ],
            "what": "/dev/sd\\*",
            "where": "/mnt/\\*"
          }
        ]
      }
    }
  }
}

I think these should match, but review-tools says:

- declaration-snap-v2:plugs_installation:mntctl:mount-control
 human review required due to 'allow-installation' constraint (interface attributes)

Please let me know via direct message if you need more specifics, I can point you to the concrete snap that is having this issue.

- Daniel

[Alex Murray (alexmurray)]

I have proposed a fix for this in review-tools but the current proposal means your declaration would have to change to be the following:

    "mount-control": {
        "allow-installation": [
            {
                "plug-attributes": {
                  "mount": [
                    {
                      "where": "/mnt/\\*",
                      "what": "/dev/sd\\*",
                      "type": "vfat",
                      "persistent": "false",
                      "options": "(rw|a?sync)"
                    }
                  ]
                },
                "on-store": [
                    "honeywell-international-inc"
                ]
            }
        ],
        "allow-auto-connection": {
            "plug-attributes": {
              "mount": [
                {
                  "where": "/mnt/\\*",
                  "what": "/dev/sd\\*",
                  "type": "vfat",
                  "persistent": "false",
                  "options": "(rw|a?sync)"
                }
              ]
            },
            "on-store": [
                "honeywell-international-inc"
            ]
        }
    },

[Daniel Manrique (roadmr)]

This is fine, we can update the snap declaration to use regexes instead.