os-prober skip message is misleading

[Henning Sprang]

os-prober appears not toe be executed when the string "osprober" is not found in /boot/grub/grub.cfg.

While I am still on my way to understand what that means and if this is probably and error, because the string to search for should be "os-prober", one thing is clearly less than ideal:

The information message tells the use to check the "GRUB_DISABLE_OS_PROBER" meaning in grub documentation.

But the reason why ths steps is skipped in that code line, is because a greo command.

The outout should tell the user so!

(ubuntu-bug uploaded my slightly modified version that changes the behaviour, this description refers to the unmodified version!)

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: grub-common 2.06-2ubuntu7
ProcVersionSignature: Ubuntu 5.15.0-30.31-generic 5.15.30
Uname: Linux 5.15.0-30-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu82
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: ubuntu:GNOME
Date: Sat May 14 22:08:19 2022
InstallationDate: Installed on 2020-04-12 (761 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017)
SourcePackage: grub2
UpgradeStatus: Upgraded to jammy on 2022-04-28 (15 days ago)
mtime.conffile..etc.grub.d.30_os-prober: 2022-05-14T22:02:14.161083

[Julian Andres Klode (juliank)]

The message is somewhat accurate though. The grub.cfg hack is the MVP to not regress existing users on grub updates, but it might not always stay that way, and it should not be considered, it's preferable to explicitly configure as the message says.

[Henning Sprang (henning)]

thanks for the quick response!

I dont understand what „MVP“ means in that context - i know that
abbreviation as minimum viable product, but that doesn’t seem to fit -
could you explain what it means here?

not totally convinced with saying it’s an “opinion” when there are in fact
two different and distinct lines where os-probing is skipped for different
reasons, but users get the same message, and one of these skips is not
dependent on the said config parameter but existence of a different string
in grub.cfg - but yeah maybe i do not yet understand the complexity enough…
--
Henning Sprang
http://www.sprang.de