[Wallaby] OVNPortForwarding._handle_lb_on_ls fails with TypeError: _handle_lb_on_ls() got an unexpected keyword argument 'context'

[yatin]

It's failing with below TraceBack:-

2022-05-10 00:38:36.539 ERROR /var/log/containers/neutron/server.log: 15 ERROR neutron_lib.callbacks.manager [req-2e5ef575-b18c-4091-8c15-b37f6bcf0fdd f1840520501c41b2a6a534525f0f90a4 bf49659cd4cb40edb393b914198ce3c9 - default default] Error during notification for neutron.services.portforwarding.drivers.ovn.driver.OVNPortForwarding._handle_lb_on_ls-4305748 router_interface, after_create: TypeError: _handle_lb_on_ls() got an unexpected keyword argument 'context'
2022-05-10 00:38:36.539 ERROR /var/log/containers/neutron/server.log: 15 ERROR neutron_lib.callbacks.manager Traceback (most recent call last):
2022-05-10 00:38:36.539 ERROR /var/log/containers/neutron/server.log: 15 ERROR neutron_lib.callbacks.manager File "/usr/lib/python3.9/site-packages/neutron_lib/callbacks/manager.py", line 197, in _notify_loop
2022-05-10 00:38:36.539 ERROR /var/log/containers/neutron/server.log: 15 ERROR neutron_lib.callbacks.manager callback(resource, event, trigger, **kwargs)
2022-05-10 00:38:36.539 ERROR /var/log/containers/neutron/server.log: 15 ERROR neutron_lib.callbacks.manager TypeError: _handle_lb_on_ls() got an unexpected keyword argument 'context'
2022-05-10 00:38:36.539 ERROR /var/log/containers/neutron/server.log: 15 ERROR neutron_lib.callbacks.manager

Was noticed in a TripleO job https://bugs.launchpad.net/tripleo/+bug/1972660.

This method was added in https://review.opendev.org/q/I0c4d492887216cad7a8155dceb738389f2886376 and backported till wallaby. Xena+ are ok, only wallaby impacted because before xena old notification format is used where arguments are passed as kwargs.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/841204

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/841204
Committed: https://opendev.org/openstack/neutron/commit/8f6d1a561dc0e5e021beae44d241c03e0d2d44fa
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8f6d1a561dc0e5e021beae44d241c03e0d2d44fa
Author: yatinkarel <email address hidden>
Date: Tue May 10 11:14:24 2022 +0530

    [Wallaby Only] Switch _handle_lb_on_ls to use old mechanism

    _handle_lb_on_ls relies on ROUTER_INTERFACE after
    create and delete events which uses old notification
    mechanism in Wallaby where data is not available as payload but
    as kwargs. Xena+ Switched to new mechanism so fix needed
    only in wallaby.

    These callbacks were added in [1].

    Also use _ovn instead of _nb_ovn in l3 plugin as
    _nb_ovn was introduced after wallaby[2].

    [1] https://review.opendev.org/q/I0c4d492887216cad7a8155dceb738389f2886376
    [2] https://review.opendev.org/c/openstack/neutron/+/718767

    Closes-Bug: #1972764
    Change-Id: Iae0622da9d42c337c398bf52aec9af1239a333c5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.4.0 release.