[api]add port_forwarding_id when list floatingip

Bug #1971646 reported by ZhouHeng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Unassigned

Bug Description

when we enable "port_forwarding" plugin and list floating ip, we can get like:
{
    "floatingips": [
        {
            "router_id": "0303bf18-2c52-479c-bd68-e0ad712a1639",
            "description": "for test with port forwarding",
            "dns_domain": "my-domain.org.",
            "dns_name": "myfip3",
            "created_at": "2018-06-15T02:12:48Z",
            "updated_at": "2018-06-15T02:12:57Z",
            "revision_number": 1,
            "project_id": "4969c491a3c74ee4af974e6d800c62de",
            "tenant_id": "4969c491a3c74ee4af974e6d800c62de",
            "floating_network_id": "376da547-b977-4cfe-9cba-275c80debf57",
            "fixed_ip_address": null,
            "floating_ip_address": "172.24.4.42",
            "port_id": null,
            "id": "898b198e-49f7-47d6-a7e1-53f626a548e6",
            "status": "ACTIVE",
            "tags": [],
            "port_forwardings": [
                {
                    "protocol": "tcp",
                    "internal_ip_address": "10.0.0.19",
                    "internal_port": 25,
                    "external_port": 2225
                },
                {
                    "protocol": "tcp",
                    "internal_ip_address": "10.0.0.18",
                    "internal_port": 16666,
                    "external_port": 8786
                }
            ],
            "qos_network_policy_id": "174dd0c1-a4eb-49d4-a807-ae80246d82f4",
            "qos_policy_id": "29d5e02e-d5ab-4929-bee4-4a9fc12e22ae"
        }
    ]
}

if we list floating ip and want to operate a port forwarding, we still need call "/v2.0/floatingips/{floatingip_id}/port_forwardings" and get port_forwarding "id".
this is inefficient.

ZhouHeng (zhouhenglc)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/840565

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
Slawek Kaplonski (slaweq) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in neutron:
status: In Progress → New
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/840565
Reason: This review is > 4 weeks without comment, and failed Zuul jobs the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Medium → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.opendev.org/c/openstack/neutron-lib/+/840796
Committed: https://opendev.org/openstack/neutron-lib/commit/9c90f78a8b70d1d718e34092cc76a89567f726e3
Submitter: "Zuul (22348)"
Branch: master

commit 9c90f78a8b70d1d718e34092cc76a89567f726e3
Author: zhouhenglc <email address hidden>
Date: Fri May 6 09:47:52 2022 +0800

    Add floating-ip-port-forwarding-detail shim extension

    if we list floating ip and want to operate a port forwarding, we cannot
    call the update 'port forwarding' api, because we don't know the port
    forwarding id.
    The reason for exposing 'internal_port_id' is also to find the
    associated port as soon as possible, so as to facilitate users to obtain
    vm information and decide whether to update this port forwarding.
    this patch adds the port forwarding returned contents: 'id' and
    'internal_port_id' when list floatingip.

    Partial-bug: #1971646

    Change-Id: I34aa6948fccc669fc729d032b540bd1aa0c17ce9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/840565
Committed: https://opendev.org/openstack/neutron/commit/b534de966ba8f0b9362a77d1024cf7ef230c9ff1
Submitter: "Zuul (22348)"
Branch: master

commit b534de966ba8f0b9362a77d1024cf7ef230c9ff1
Author: zhouhenglc <email address hidden>
Date: Thu May 5 11:18:07 2022 +0800

    [api]adds port_forwarding id when list floatingip

    if we list floating ip and want to operate a port forwarding, we cannot
    call the update 'port forwarding' api, because we don't know the port
    forwarding id.
    this patch adds the port forwarding returned contents: 'id' and
    'internal_port_id' when list floatingip.

    Closes-bug: #1971646
    Depends-On: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/840584

    Change-Id: Ie1d9169cd07547491144776311d77d49b483d5ae

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.0.0.0rc1

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.