TASK [os_tempest : Override tempestconf profile] - The task includes an option with an undefined variable failing on undercloud-containers jobs

[Bhagyashri Shewale]

2022-04-28 01:06:41.806143 | primary | TASK [os_tempest : Override tempestconf profile] *******************************
2022-04-28 01:06:41.806159 | primary | Thursday 28 April 2022 01:06:41 -0400 (0:00:00.049) 0:00:48.063 ********
2022-04-28 01:06:41.834261 | primary | fatal: [undercloud]: FAILED! => {"msg": "The task includes an option with an undefined variable. The error was: {'debug': True, 'create': True, 'os-cloud': '{{ tempest_cloud_name }}', 'out': '{{ tempest_workspace }}/etc/tempest.conf', 'network-id': '{{ tempest_neutron_public_network_id }}', 'overrides': '{{ tempest_tempestconf_profile_overrides }}'}: 'tempest_neutron_public_network_id' is undefined\n\nThe error appears to be in '/home/zuul/workspace/.quickstart/share/ansible/roles/os_tempest/tasks/tempestconf.yml': line 26, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Override tempestconf profile\n ^ here\n"}
2022-04-28 01:06:41.836051 | primary |
2022-04-28 01:06:41.836088 | primary | PLAY RECAP *********************************************************************
2022-04-28 01:06:41.836139 | primary | undercloud : ok=25 changed=10 unreachable=0 failed=1 skipped=121 rescued=0 ignored=0
2022-04-28 01:06:41.836227 | primary |

Affected job:

undercloud-containers - for all releases

[1]: https://logserver.rdoproject.org/48/39848/3/check/periodic-tripleo-ci-centos-9-undercloud-containers-wallaby/69b39c1/job-output.txt

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/839694

[Bhagyashri Shewale (bhagyashri-shewale)]

The change in openstack-ansible-os_tempest recently add one parameter [1] which is not defined in tripleo-quicked-extra so defined here [2]

[1]: https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/803477

[2]: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/839694

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/839724

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/839724
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/a8c10578d2d7d9b94dc424bca3e7b5eab968543e
Submitter: "Zuul (22348)"
Branch: master

commit a8c10578d2d7d9b94dc424bca3e7b5eab968543e
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Thu Apr 28 17:22:01 2022 +0530

    Enable neutron service for creating public network

    https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/803477
    modifies the os_tempest role to create only specific tempest
    resources.

    Earlier neutron public network id is setted when public
    network exists but due to above patch, we need to make
    sure neutron service is enabled and tempest_public_net_create
    is set to true (default to true).

    It fixes the same and also avoids creating private network on
    undercloud.

    Closes-Bug: #1970710

    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>
    Change-Id: I73e0dcb86de532cb2a0454b1940cdf330ba276c0

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/839694
Committed: https://opendev.org/openstack/tripleo-quickstart-extras/commit/bedde96ad9d276a7c4b3c8d3c0b8c124e3453ca4
Submitter: "Zuul (22348)"
Branch: master

commit bedde96ad9d276a7c4b3c8d3c0b8c124e3453ca4
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Thu Apr 28 13:00:56 2022 +0530

    Add tempest_{private_net_create, router_create} vars in os_tempest

    https://review.opendev.org/c/openstack/openstack-ansible-os_tempest/+/803477
    modifies the os_tempest role to create only specific tempest
    resources.

    Earlier private network and routers were created when network
    related vars are set. Due to above patch, we are no longer creating
    that.

    That's why tempest_neutron_public_network_id is not getting
    set and leading to failure of tempestconf generation via os_tempest.

    Setting above vars fixes the issue.

    Closes-Bug: #1970710

    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>
    Change-Id: If7318f501c72ea5fb012e2935a316eb7c3d15e5e