unable to use /dev/disk/by-path for cc_disk_setup

[Brendan Germain]

fs_setup:
- device: /dev/disk/by-path/pci-0000:18:00.0-nvme-1

or

fs_setup:
- device: /dev/disk/by-path/pci-0000:18:00.0-nvme-1-part1

yields:

cc_disk_setup.py[WARNING]: Partition '0-nvme-1' from dotted device name '/dev/disk/by-path/pci-0000:18:00.0-nvme-1' overrides 'partition' key

cc_disk_setup.py[WARNING]: Partition '0-nvme-1-part1' from dotted device name '/dev/disk/by-path/pci-0000:18:00.0-nvme-1-part1' overrides 'partition' key

the dots in these device paths do not indicate a partition and it seems there is no way to disable the partition auto detection.

you should be able to use any of the /dev/disk/ paths. by-id by-partuuid by-path by-uuid

[Brendan Germain (bgermain1689)]

this does work when using a cloud-init version recent enough to leverage device_aliases at this commit https://github.com/canonical/cloud-init/commit/758acf976f2cb67a85411467fa5fca2ea17a2283 which i monkey patched, though i'm not sure using aliases should be a requirement to target these devices.

[James Falcon (falcojr)]

Given how we expect the <device>.<partition_num> format, this may be hard to fix in a way that won't cause other parsing issues. Either way, this could be more robust than it is. Since we already have solution/workaround using aliases, I'm triaging this as low priority.

[James Falcon (falcojr)]

Tracked in Github Issues as https://github.com/canonical/cloud-init/issues/3969