Test tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_update_instance_port_admin_state is failing constantly since 7.04.2022

[Slawek Kaplonski]

It is failing in the neutron-ovs-tempest-slow periodic job every day since 7.04.2022.
Failure example: https://71dffc4e35d369b68ca9-4d92b13c04e5cbfc4c00e2b757cddf9c.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/neutron/master/neutron-ovs-tempest-slow/9866a21/testr_results.html

Stacktrace:

Traceback (most recent call last):
  File "/opt/stack/tempest/tempest/common/utils/__init__.py", line 70, in wrapper
    return f(*func_args, **func_kwargs)
  File "/opt/stack/tempest/tempest/scenario/test_network_basic_ops.py", line 717, in test_update_instance_port_admin_state
    self._check_public_network_connectivity(
  File "/opt/stack/tempest/tempest/scenario/test_network_basic_ops.py", line 212, in _check_public_network_connectivity
    self.check_vm_connectivity(
  File "/opt/stack/tempest/tempest/scenario/manager.py", line 948, in check_vm_connectivity
    self.assertTrue(self.ping_ip_address(ip_address,
  File "/usr/lib/python3.8/unittest/case.py", line 765, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true : Public network connectivity check failed. Reason: after updating admin_state_up of instance port to True
Timed out waiting for 172.24.5.179 to become reachable

It seems that patch https://review.opendev.org/c/openstack/neutron/+/819567 is the culprit of that issue

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/837685

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/838444

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/838445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/838444
Committed: https://opendev.org/openstack/neutron/commit/8dfb24a9332673c8b972f26cb92f5d4024b1bf6f
Submitter: "Zuul (22348)"
Branch: master

commit 8dfb24a9332673c8b972f26cb92f5d4024b1bf6f
Author: LIU Yulong <email address hidden>
Date: Tue Apr 19 15:13:18 2022 +0800

    Remove block flow when port UP

    Port admin state down will add 4095 tag to it while
    it is adding a drop flow for this ofport.

    When port is back UP again, remove the drop flow.

    Closes-bug: #1968896
    Change-Id: Ie8f67def69ae0e5d425d0e6fc43e35373a96bd88

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/838445
Committed: https://opendev.org/openstack/neutron/commit/c4adec924a1f189fbe5750f1b413db0d0f23c39a
Submitter: "Zuul (22348)"
Branch: master

commit c4adec924a1f189fbe5750f1b413db0d0f23c39a
Author: LIU Yulong <email address hidden>
Date: Tue Apr 19 15:17:19 2022 +0800

    Remove useless function _add_port_tag_info

    This reverts commit: b83fedbd78a441cf34d53dba35a3ccff7d8f4ac5.

    Since port is set to dead by default after the commits of:
    7aae31c9f9ed938760ca0be3c461826b598c7004
    0ddca284542aed89df4a22607a2da03f193f083c

    And we add the local vlan tag to the port right after it is
    bound to aviod trunk port flood issue:
    c63ebef2d58e15f4388cf064066f77b503a2f841

    So that _add_port_tag_info function is not necessary anymore,
    and we will save a large OVSDB read action which is dumping
    the entire table of Port, for hosts with a huge number of
    ports this is time-comsuming. So removed it.

    Related-Bug: #1968896
    Related-Bug: #1952567
    Change-Id: Iefd765d497c7e2d4bb093052478185125b907025

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/837685

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.