offline-neutron-morph-db action fails on Yoga

[Billy Olsen]

The offline-neutron-morph-db action fails on Yoga with a stack trace (follows after explanation). This is due to the updated version of sqlalchemy in Yoga. Sqlalchemy 1.4 dropped support for the row.values() and row.itervalues().

Stacktrace:

{'Code': '0', 'Stderr': 'offline-neutron-morph-db: OUTPUT FROM MORPH ON STDE
RR:
MySQL SQL mode is \'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_ENGINE_SUBSTITUTION\', consider enabling TRADITIONAL or STRICT_ALL_TABLES
Traceback (mo
st recent call last):
  File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/charm/files/scripts/neutron_offline_network_type_update.py", line 255, in <module>
    sys.exit(main(sys.argv))
  File "/var/li
b/juju/agents/unit-neutron-api-plugin-ovn-0/charm/files/scripts/neutron_offline_network_type_update.py", line 93, in main
    n_morphed = morph_networks(db_session, network_type, to_network_type)
  File "/var/
lib/juju/agents/unit-neutron-api-plugin-ovn-0/charm/files/scripts/neutron_offline_network_type_update.py", line 238, in morph_networks
    for segment_id, network_id, network_type, vni in get_network_segments(\
n File "/var/lib/juju/agents/unit-neutron-api-plugin-ovn-0/charm/files/scripts/neutron_offline_network_type_update.py", line 218, in get_network_segments
    yield row.values()
AttributeError: Could not locate column in row for column \'values\'

', 'Stdout': 'offline-neutron-morph-db: OUTPUT FROM MORPH ON STDOUT:

'}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-neutron-api-plugin-ovn/+/837445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-neutron-api-plugin-ovn/+/837445
Committed: https://opendev.org/openstack/charm-neutron-api-plugin-ovn/commit/d20fda9b179d5cbf29c97dc7926593065810e101
Submitter: "Zuul (22348)"
Branch: master

commit d20fda9b179d5cbf29c97dc7926593065810e101
Author: Billy Olsen <email address hidden>
Date: Mon Apr 11 19:36:10 2022 -0700

    Fix offline network migration for sqlalchemy 1.4+

    Sqlalchemy 1.4 dropped support for RowProxy and Row now behaves like a
    tuple. This causes row and column iteration to fail using the RowProxy
    semantics as the iteration methods are no longer there. Fix this by
    checking which method needs to be used. This is necessary for backwards
    compatibility with the Xena release for the Yoga branch.

    Closes-Bug: #1968647
    Change-Id: I6a4adbd87bd59ad3a4b0a8cef187d82f4e128084