[router qos]qos binding is not clear after remove gateway

[Liu Xie]

As the title describes, after remove gateway for a router, we could find the qos binding is remain.
And if we delete this qos policy, we could meet the error of QosPolicyInUse.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Right, I've tested with OVN backend but I think that doesn't depend on the backend at all.

I'll take it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/837143

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/837143
Committed: https://opendev.org/openstack/neutron/commit/8ad6c3bf60081ebf19c1cadd9c46e1f5bf504892
Submitter: "Zuul (22348)"
Branch: master

commit 8ad6c3bf60081ebf19c1cadd9c46e1f5bf504892
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 22 16:39:42 2022 +0000

    [L3][QoS] Remove router QoS binding when GW is removed

    Now when the external gateway of a router is removed, the QoS policy
    assigned to this router is removed too. A router can only have a QoS
    policy assigned if a gateway port is attached; if the port is removed,
    the QoS binding must be removed too.

    Closes-Bug: #1968269
    Change-Id: Iced254259170972a9699aa35ae8062776e11285d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/839016

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/839017

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/839018

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/839016
Committed: https://opendev.org/openstack/neutron/commit/061a80deb420a74ed529e3f485a5eb8c8ffdd18f
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 061a80deb420a74ed529e3f485a5eb8c8ffdd18f
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 22 16:39:42 2022 +0000

    [L3][QoS] Remove router QoS binding when GW is removed

    Now when the external gateway of a router is removed, the QoS policy
    assigned to this router is removed too. A router can only have a QoS
    policy assigned if a gateway port is attached; if the port is removed,
    the QoS binding must be removed too.

    Closes-Bug: #1968269
    Change-Id: Iced254259170972a9699aa35ae8062776e11285d
    (cherry picked from commit 8ad6c3bf60081ebf19c1cadd9c46e1f5bf504892)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/839017
Committed: https://opendev.org/openstack/neutron/commit/1ef5d4001f385128041e86396cedd3ffb2096967
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 1ef5d4001f385128041e86396cedd3ffb2096967
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 22 16:39:42 2022 +0000

    [L3][QoS] Remove router QoS binding when GW is removed

    Now when the external gateway of a router is removed, the QoS policy
    assigned to this router is removed too. A router can only have a QoS
    policy assigned if a gateway port is attached; if the port is removed,
    the QoS binding must be removed too.

    Closes-Bug: #1968269
    Change-Id: Iced254259170972a9699aa35ae8062776e11285d
    (cherry picked from commit 8ad6c3bf60081ebf19c1cadd9c46e1f5bf504892)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/839018
Committed: https://opendev.org/openstack/neutron/commit/ac7c002b617c02629938b31649934a48c42c2dbf
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ac7c002b617c02629938b31649934a48c42c2dbf
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 22 16:39:42 2022 +0000

    [L3][QoS] Remove router QoS binding when GW is removed

    Now when the external gateway of a router is removed, the QoS policy
    assigned to this router is removed too. A router can only have a QoS
    policy assigned if a gateway port is attached; if the port is removed,
    the QoS binding must be removed too.

    Closes-Bug: #1968269
    Change-Id: Iced254259170972a9699aa35ae8062776e11285d
    (cherry picked from commit 8ad6c3bf60081ebf19c1cadd9c46e1f5bf504892)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.