zsysd fails with "index out of range" go-libzfs (*Pool).ReloadProperties

[Felix]

Good day,
today during upgrading my system running 22.04 (dev branch) with apt, I noticed error messages relating to problems contacting the zsys daemon. I then checked the status and found the below log lines with journalctl. A reboot after updating has not fixed the problem, the daemon is still not starting (same stacktrace).

-> Note: during above mentioned upgrade, the package was updated from 0.5.8build1 -> 0.5.8build2.

EDIT 2022-04-02: Manually downloading & downgrading to the "old" build 0.5.8build1 from https://launchpad.net/ubuntu/impish/amd64/zsys/0.5.8build1 fixes the problem.

Apr 02 19:15:26 zsysd[6423]: panic: runtime error: index out of range [33] with length 33
Apr 02 19:15:26 zsysd[6423]: goroutine 1 [running]:
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/bicomsystems/go-libzfs.(*Pool).ReloadProperties(0xc0000f4ea0)
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/bicomsystems/go-libzfs/zpool.go:518 +0x56e
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/bicomsystems/go-libzfs.(*Dataset).Pool(0x400?)
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/bicomsystems/go-libzfs/zfs.go:306 +0x55
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs.(*Dataset).refreshProperties(0xc0000c2e00, {0xad3d20, 0xc0000bc000})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs/helpers.go:41 +0x41d
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs.newDatasetTree({0xad3d20, 0xc0000bc000}, {0xad7fe8?, 0xc000217860?}, 0xc0000f55c0)
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs/helpers.go:214 +0x258
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs.(*Zfs).Refresh(0xc0000ceae0, {0xad3d20, 0xc0000bc000})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs/zfs.go:118 +0x2d2
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs.New({0xad3d20, 0xc0000bc000}, {0xc0000f56c0, 0x1, 0xc0000f56d8?})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/zfs/zfs.go:93 +0xf7
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/machines.New({0xad3d20, _}, {_, _}, {_, _, _})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/machines/machines.go:128 +0x337
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/daemon.New({0x9fd26f, 0xf}, {0x0, 0x0, 0xacfce0?})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/internal/daemon/daemon.go:115 +0x57a
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/cmd/zsysd/daemon.glob..func2(0xe29940?, {0xea2c40?, 0x0?, 0x0?})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/cmd/zsysd/daemon/zsysd.go:30 +0x52
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/spf13/cobra.(*Command).execute(0xe29940, {0xc0000a0210, 0x0, 0x0})
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/spf13/cobra/command.go:830 +0x663
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xe29940)
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/spf13/cobra/command.go:914 +0x2ee
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/spf13/cobra.(*Command).Execute(...)
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/vendor/github.com/spf13/cobra/command.go:864
Apr 02 19:15:26 zsysd[6423]: main.main()
Apr 02 19:15:26 zsysd[6423]: github.com/ubuntu/zsys/cmd/zsysd/main.go:36 +0xb3
Apr 02 19:15:26 systemd[1]: zsysd.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

Further system info:

lsb_release -rd:
Description: Ubuntu Jammy Jellyfish (development branch)
Release: 22.04

Package version of zsys: 0.5.8build2
-> Note: during above mentioned upgrade, the package was updated from 0.5.8build1 -> 0.5.8build2.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: zsys 0.5.8build2
ProcVersionSignature: Ubuntu 5.15.0-23.23-generic 5.15.27
Uname: Linux 5.15.0-23-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu80
Architecture: amd64
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Sat Apr 2 19:25:13 2022
InstallationDate: Installed on 2022-03-16 (16 days ago)
InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012)
Mounts: Error: [Errno 40] Zu viele Ebenen aus symbolischen Links: '/proc/mounts'
ProcKernelCmdLine: BOOT_IMAGE=/BOOT/ubuntu_wvwllv@/vmlinuz-5.15.0-23-generic root=ZFS=rpool/ROOT/ubuntu_wvwllv ro quiet splash vt.handoff=1
RelatedPackageVersions:
 zfs-initramfs 2.1.2-1ubuntu3
 zfsutils-linux 2.1.2-1ubuntu3
SourcePackage: zsys
UpgradeStatus: Upgraded to jammy on 2022-03-16 (16 days ago)
ZFSImportedPools:
 NAME SIZE ALLOC FREE CKPOINT EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
 bpool 1.88G 1.09G 803M - - 4% 58% 1.00x ONLINE -
 rpool 920G 30.0G 890G - - 0% 3% 1.00x ONLINE -
ZFSListcache-bpool:
 bpool /boot off on on off on off on off - none - - - - - - - -
 bpool/BOOT none off on on off on off on off - none - - - - - - - -
 bpool/BOOT/ubuntu_wvwllv /boot on on on off on off on off - none - - - - - - - -
ZSYSDump: Error: command ['zsysctl', 'service', 'dump'] failed with exit code 1: level=error msg="couldn't connect to zsys daemon: connection error: desc = \"transport: Error while dialing dial unix /run/zsysd.sock: connect: connection refused\""

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.