Printer Settings UI Angular Port

Bug #1965326 reported by Bill Erickson
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.8 / Wishlist

Let's port the printer settings (Admin -> Workstation Admin -> Printer Settings) UI to Angular. Patch on the way.

Revision history for this message
Bill Erickson (berick) wrote :

A branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1965326-print-admin-angular

Beware this builds atop the code for bug #1955838, because it assumes the presences of the browser-native printing option.

Noting like the code for bug #1955838, we are using this code in production.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.9-beta → none
Revision history for this message
John Amundson (jamundson) wrote :

Testing this for bug squashing week.

One oddity - and I'm not sure if there's a good way to resolve this - is that the warning "Hatch printing is not enabled on this browser. The settings below will have no effect until Hatch printing is enabled." does not go away when enabling Hatch. It only goes away when logging out and logging back in, which is confusing.

Also want to note that I filed a related wishlist bug to remove the "Print Service ("Hatch")" page entirely and move over the checkbox to enable Hatch to this screen - https://bugs.launchpad.net/evergreen/+bug/1983032

Revision history for this message
John Amundson (jamundson) wrote :

Testing again for Feedback fest.

The "Hatch printing is not enabled on this browser. The settings below will have no effect until Hatch printing is enabled." still does not go away until logout, which is still very confusing.

Revision history for this message
John Amundson (jamundson) wrote :

Testing again for Bug Squashing Week.

The "Hatch printing is not enabled on this browser. The settings below will have no effect until Hatch printing is enabled." still does not go away until logout, which is still very confusing.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

New rebased branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1965326-print-admin-angular-v2

This adds the changes requested in bug #1983032, which have the side effect of addressing the confusion John mentions above.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
milestone: none → 3.12-beta
Revision history for this message
John Amundson (jamundson) wrote :

Thank you for combining the pages, Bill! The checkbox is behaving perfectly and so is the expected behavior when Hatch is and isn't installed. I may be biased, but I'm a big fan of the combined page and rename.

I've been able to test some of the actual behavior of the settings, and they also seem to be working, but I don't have a real printer handy to fully test. I've been testing with PDF and browser printing, and both those options are working great!

Others are welcome to test, but I hope to have some tests in with actual printers this week, as well.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Elizabeth Davis (elidavis) wrote (last edit ):

Tested with a Star TSP100 receipt printer. It worked as expected. Set up felt more streamlined and test prints printed between my receipt printer and PDF printer as expected.

I have tested this code and consent to signing off on it with my name, Elizabeth Davis and my email address, <email address hidden>.

tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Merged to main for 3.12. Thanks All!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.