Build failure involving Mellanox v5.5 updates ("Invalid srpm path ... mstflint")

[M. Vefa Bicakci]

Brief Description
-----------------
After Mellanox OFED v5.5 updates were merged, I noticed that there is a small build failure involving the mstflint package.

In summary, when I run the following commands:

  ${MY_REPO_ROOT_DIR}/stx-tools/toCOPY/generate-centos-repo.sh /import/mirrors/starlingx
  ${MY_REPO_ROOT_DIR}/stx-tools/toCOPY/populate_downloads.sh /import/mirrors/starlingx
  build-srpms --clean mstflint
  build-srpms mstflint

I encounter an error like the following:
  b2: ERROR: build_dir (438): Invalid srpm path 'repo:stx/downloads/mstflint-4.16.0-1.55103.src.rpm', evaluated as '.../stx/downloads/mstflint-4.16.0-1.55103.src.rpm', found in '.../stx/kernel/userspace/mellanox/mstflint/centos/srpm_path'

I already have a solution for this issue; I am reporting this bug to have a reference for the Closes-Bug field in the commit message.

Severity
--------
Minor: An easily resolved build failure.

Steps to Reproduce
------------------
Please see the description.

Expected Behavior
------------------
Build does not fail.

Actual Behavior
----------------
Build fails as noted in the description.

Reproducibility
---------------
Reliably reproducible

System Configuration
--------------------
Not applicable.

Branch/Pull Time/Commit
-----------------------
Commit 006c2597033b in StarlingX/kernel repository.

Last Pass
---------
Prior to commit 006c2597033b in StarlingX/kernel repository.

Timestamp/Logs
--------------
Please see the description.

Test Activity
-------------
Developer build.

Workaround
----------
None.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/kernel/+/833211
Committed: https://opendev.org/starlingx/kernel/commit/ad868a4450e5d820c0973d9c69999964d901dbc5
Submitter: "Zuul (22348)"
Branch: master

commit ad868a4450e5d820c0973d9c69999964d901dbc5
Author: M. Vefa Bicakci <email address hidden>
Date: Thu Mar 10 18:29:10 2022 -0500

    centos_extra_downloads.lst: Add mstflint SRPM

    The addition of mstflint to the centos_extra_downloads.lst was forgotten
    with commit 006c2597033b ("mlnx-ofa_kernel: Add mlnx firmware tools").
    This was also not noticed during the code review.

    Not having mstflint listed in the centos_extra_downloads.lst file
    results in the following build-srpms preparation failure, especially
    when the source RPM is not manually placed in
    "${MY_REPO}/stx/downloads":

      $ ${MY_REPO_ROOT_DIR}/stx-tools/toCOPY/generate-centos-repo.sh \
        /import/mirrors/starlingx
      # Output redacted

      $ ${MY_REPO_ROOT_DIR}/stx-tools/toCOPY/populate_downloads.sh \
        /import/mirrors/starlingx
      # Output redacted

      $ build-srpms --clean mstflint && build-srpms mstflint
      # Some output redacted
      b2: ERROR: build_dir (438): Invalid srpm path \
        'repo:stx/downloads/mstflint-4.16.0-1.55103.src.rpm', \
        evaluated as \
        '.../stx/downloads/mstflint-4.16.0-1.55103.src.rpm', \
        found in \
        '.../stx/kernel/userspace/mellanox/mstflint/centos/srpm_path'
      # Some output redacted

    This commit resolves this issue by adding the missing entry to the
    centos_extra_downloads.lst file.

    Change-Id: Ib49d9af6b40e027876e39a98d696b2b54f67f6bd
    Closes-Bug: 1964543
    Fixes: 006c2597033b ("mlnx-ofa_kernel: Add mlnx firmware tools")
    Signed-off-by: M. Vefa Bicakci <email address hidden>

[Ghada Khalil (gkhalil)]

screening: stx.7.0 / critical - build issue introduced by recent commit