xhci: Fix command ring abort, write all 64 bits to CRCR register.

[Amedee Van Gasse]

Upstream mainline kernel includes patch v5.15-rc5-4-gff0e50d3564f.
This patch was included in the Ubuntu kernel as Ubuntu-5.13.0-22.22-387-g0fc979747dec, available in Ubuntu kernels 5.13.0-23 and up.

The patch is incomplete, which causes an issue with some xHC controllers.
An additional patch was made to the upstream mainline kernel, which fixes the issue that was introduced: v5.16-rc3-1-g09f736aa9547. This patch does not yet have a corresponding commit in the Ubuntu kernel repository for Ubuntu 21.10; and Ubuntu 22.04 will use the 5.15 kernel, which does also not include the second patch.

Discussion of the first patch (already in Ubuntu kernel) can be found on the kernel.org mailing list: https://<email address hidden>

Discussion of the second patch (not yet in Ubuntu kernel):
https://<email address hidden>/

Request to include upstream patch v5.16-rc3-1-g09f736aa9547 into the kernels for Ubuntu 21.10 (5.13 kernels) and Ubuntu 22.04 LTS (5.15 kernels).

ProblemType: Bug
DistroRelease: Ubuntu 21.10
Package: linux-image-5.13.0-22-generic 5.13.0-22.22
ProcVersionSignature: Ubuntu 5.13.0-22.22-generic 5.13.19
Uname: Linux 5.13.0-22-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu71
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC2: amedee 4158 F.... pulseaudio
 /dev/snd/controlC3: amedee 4158 F.... pulseaudio
 /dev/snd/controlC0: amedee 4158 F.... pulseaudio
 /dev/snd/controlC1: amedee 4158 F.... pulseaudio
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Thu Mar 3 22:23:43 2022
HibernationDevice: RESUME=UUID=edec0bf3-448f-4e5c-a21a-ef9624572973
InstallationDate: Installed on 2022-01-30 (32 days ago)
InstallationMedia: Ubuntu 21.10 "Impish Indri" - Release amd64 (20211012)
IwConfig:
 lo no wireless extensions.

 eno1 no wireless extensions.
MachineType: Gigabyte Technology Co., Ltd. Z370 AORUS Gaming K3
ProcFB: 0 EFI VGA
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.13.0-22-generic root=/dev/mapper/hostname-root ro quiet splash vt.handoff=7
RebootRequiredPkgs: Error: path contained symlinks.
RelatedPackageVersions:
 linux-restricted-modules-5.13.0-22-generic N/A
 linux-backports-modules-5.13.0-22-generic N/A
 linux-firmware 1.201.4
RfKill:
 0: hci0: Bluetooth
  Soft blocked: no
  Hard blocked: no
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 11/28/2019
dmi.bios.release: 5.12
dmi.bios.vendor: American Megatrends Inc.
dmi.bios.version: F15a
dmi.board.asset.tag: Default string
dmi.board.name: Z370 AORUS Gaming K3-CF
dmi.board.vendor: Gigabyte Technology Co., Ltd.
dmi.board.version: x.x
dmi.chassis.asset.tag: Default string
dmi.chassis.type: 3
dmi.chassis.vendor: Default string
dmi.chassis.version: Default string
dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrF15a:bd11/28/2019:br5.12:svnGigabyteTechnologyCo.,Ltd.:pnZ370AORUSGamingK3:pvrDefaultstring:rvnGigabyteTechnologyCo.,Ltd.:rnZ370AORUSGamingK3-CF:rvrx.x:cvnDefaultstring:ct3:cvrDefaultstring:skuDefaultstring:
dmi.product.family: Default string
dmi.product.name: Z370 AORUS Gaming K3
dmi.product.sku: Default string
dmi.product.version: Default string
dmi.sys.vendor: Gigabyte Technology Co., Ltd.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This change was made by a bot.

[Jonathan George (jageorge-austin)]

I have also experienced this upstream bug which causes the USB hubs to drop all attached devices. This means that external drive devices all disappear almost as quickly as they appear. Basically it's a show stopper since I can't use my USB attached data drives at all any more.

[Amedee Van Gasse (amedee)]

I have expected this to happen not just for USB input devices but for all USB devices, like your external drives. I just don't have any other devices at hand to verify.

For reference, here's a related question on AskUbuntu: https://askubuntu.com/questions/1394480/keyboard-mouse-stop-working-with-kernel-ubuntu-5-13-0-22-22-387-g0fc979747dec

[Jonathan George (jageorge-austin)]

This appears to be the resolution upstream: https://lore.kernel.org/linux-usb/Yay1EiY%<email address hidden>/

[Amedee Van Gasse (amedee)]

Well, yes, the message you linked does not contain any new information; the two commits there (the one that introduced the bug and the one that fixes it) are already mentioned here in the first message.

The intent of this bug report is to pull in the fixing bugfix from upstream.

[Amedee Van Gasse (amedee)]

See also the kernel mailing list message from 26 November 2021: https://<email address hidden>/

[Jonathan George (jageorge-austin)]

You referenced the original report, patch, and promotion to Linux Next for review. The new information is that the resolution for the issue you referenced was reviewed and promoted by Greg KH from Linux Next to his queue for Linus https://lore.kernel.org/all/Yayq%2FXdb%2FpHSS7%<email address hidden>/ in the production kernel back on December 5, 2021. BTW it was accepted into Linus's mainline queue with commit https://lore.kernel<email address hidden>/ later that day.
Interestingly Greg mentioned merging these changes into the stable queue. If he actually did so (I didn't notice where) it might help to make sure that 21.10 and 22.04 are immediately rebased to include the mainline included patches.

[Amedee Van Gasse (amedee)]

I fully agree on immediately rebasing 21.10 and 22.04. I hope that this bug report helps to make sure that this happens.