[MIR] libadwaita-1
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| libadwaita-1 (Ubuntu) |
Fix Released
|
Undecided
|
Didier Roche-Tolomelli | ||
Bug Description
[Availability]
The package libadwaita-1 is already in Ubuntu universe.
The package libadwaita-1 build for the architectures it is designed to work on.
It currently builds and works for architetcures: amd64 arm64 armhf ppc64el riscv64 s390x
Link to package https:/
[Rationale]
- The package libadwaita-1 is required in Ubuntu main because gnome-shell depends on it to be able to load extensions which use that library.
- The package libadwaita-1 is required in Ubuntu main no later than March 28 which is beta freeze since it's going to block the new gnome-shell version to migrate out of proposed.
[Security]
- No CVEs/security issues in this software in the past
- no executables in `/sbin` and `/usr/sbin`
- Package does not install services, timers or recurring jobs
- Packages does not open privileged ports (ports < 1024)
- Packages does not contain extensions to security-sensitive software
[Quality assurance - function/usage]
- The package works well right after install
[Quality assurance - maintenance]
- The package is maintained well in Debian/Ubuntu, it is rather new and has 1 low importance bug reported
- Ubuntu https:/
- Debian https:/
- The package does not deal with exotic hardware we cannot support
[Quality assurance - testing]
- The package runs a test suite on build time, if it fails
it makes the build fail, link to build log https:/
- The package runs an autopkgtest, and is currently passing on this list of architectures <amd64 arm64 armhf ppc64el s390x>, https:/
[Quality assurance - packaging]
- debian/watch is present and works
- This package has no important lintian warnings
- Recent log from the debian service, https:/
- Lintian overrides are not present
- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies
- The package will be installed by default, but does not ask debconf questions
- Packaging and build is easy, link to d/rules https:/
[UI standards]
- Application is end-user facing, Translation is present, via standard gettext
[Dependencies]
- No further depends or recommends dependencies that are not yet in main
[Standards compliance]
- This package correctly follows FHS and Debian Policy
[Maintenance/Owner]
- Owning Team will be Ubuntu Desktop
- Team is already subscribed to the package
- This does not use static builds
- This does not use vendored code
[Background information]
The Package description explains the package well
Upstream Name is libadwaita
Link to upstream project https:/
| Changed in libadwaita-1 (Ubuntu): | |
| assignee: | nobody → Didier Roche (didrocks) |
| Didier Roche-Tolomelli (didrocks) wrote | #1 |
| Changed in libadwaita-1 (Ubuntu): | |
| status: | New → Fix Committed |
| Didier Roche-Tolomelli (didrocks) wrote | #2 |
| Changed in libadwaita-1 (Ubuntu): | |
| status: | Fix Committed → Fix Released |
Review for Package: libadwaita-1
[Summary]
MIR team ACK. To me, it doesn’t seem this needs a security review. It’s well maintained, part of the core GNOME stack now. Desktop packages is already subscribed.
Notes:
TODO: - add todos, issues or special cases to discuss
Required TODOs:
TODO: - TBD (Please add them numbered for later reference)
Recommended TODOs:
RULE: - Does it have a team bug subscriber? (This is not a blocker for a MIR
RULE: team ACK, but needs to be provided before the package can be promoted
RULE: by an AA)
TODO: - The package should get a team bug subscriber before being promoted
TODO: - TBD (Please add them numbered for later reference)
[Duplication]
There is no other package in main providing the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- checked with check-mir
- not listed in seeded-in-ubuntu
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
OK:
- not a go package, no extra constraints to consider in that regard
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
- test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
- if special HW does prevent build/autopkgtest is there a test plan, code,
log provided?
- no new python2 dependency
[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking is in place
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list
(fix, or the work-around should be directly in the package,
see https:/
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
tests)
- no use of user nobody
- no use of setuid
- use of setuid, but ok because TBD (prefer systemd to set those
for services)
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebki...