assertion triggered in link_enc_cfg_validate in amdgpu on resume from s2idle

[You-Sheng Yang]

The following WARNING shows up on resume from s2idle on some OEM platforms:

[ 136.701141] ------------[ cut here ]------------
[ 136.701146] WARNING: CPU: 0 PID: 1630 at drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_enc_cfg.c:588 link_enc_cfg_validate+0x1f6/0x240 [amdgpu]
[ 136.701417] Modules linked in: hid_logitech_hidpp hid_logitech_dj michael_mic rfcomm snd_usb_audio snd_usbmidi_lib cmac algif_hash r8153_ecm algif_skcipher qrtr_mhi r8152 af_alg cdc_mbim cdc_wdm cdc_ncm cdc_ether usbnet joydev mii intel_rapl_msr intel_rapl_common bnep edac_mce_amd snd_acp6x_pdm_dma snd_soc_dmic snd_soc_acp6x_mach snd_soc_core snd_compress ac97_bus snd_pcm_dmaengine qrtr ns snd_ctl_led ath11k_pci ath11k snd_hda_codec_realtek nls_iso8859_1 qmi_helpers snd_hda_codec_generic amdgpu mac80211 kvm iommu_v2 gpu_sched drm_ttm_helper snd_hda_codec_hdmi btusb crct10dif_pclmul ttm btrtl thinkpad_acpi ghash_clmulni_intel uvcvideo btbcm snd_seq_midi btintel snd_hda_intel nvram videobuf2_vmalloc snd_seq_midi_event snd_intel_dspcfg aesni_intel drm_kms_helper videobuf2_memops snd_intel_sdw_acpi bluetooth videobuf2_v4l2 videobuf2_common think_lmi crypto_simd cec input_leds snd_hda_codec videodev cryptd platform_profile usbhid efi_pstore ecdh_generic serio_raw rapl cfg80211 wmi_bmof
[ 136.701485] firmware_attributes_class ecc ledtrig_audio mc rc_core snd_rawmidi snd_hda_core snd_pci_acp6x snd_hwdep i2c_algo_bit fb_sys_fops mhi snd_seq syscopyarea snd_pcm sysfillrect libarc4 sysimgblt snd_rn_pci_acp3x snd_seq_device snd_pci_acp3x snd_timer ccp snd soundcore hid_sensor_accel_3d hid_sensor_magn_3d hid_sensor_gyro_3d hid_sensor_trigger industrialio_triggered_buffer kfifo_buf hid_sensor_iio_common mac_hid amd_pmc industrialio acpi_tad sch_fq_codel msr parport_pc ppdev lp drm parport ip_tables x_tables autofs4 hid_sensor_hub hid_generic crc32_pclmul psmouse nvme i2c_piix4 nvme_core xhci_pci amd_sfh xhci_pci_renesas wmi i2c_hid_acpi video i2c_hid hid
[ 136.701526] CPU: 0 PID: 1630 Comm: Xorg Not tainted 5.14.0-1022-oem #24-Ubuntu
[ 136.701530] Hardware name: LENOVO 21D2SIT061/21D2SIT061, BIOS N3GET11WQ (0.11 ) 01/14/2022
[ 136.701532] RIP: 0010:link_enc_cfg_validate+0x1f6/0x240 [amdgpu]
[ 136.701930] Code: 83 7d 10 00 74 24 0f b6 83 e0 01 00 00 49 83 c4 01 44 39 e0 7f d4 45 84 ff 74 0f 80 7d 8b 00 74 09 0f b6 45 90 44 20 f0 75 04 <0f> 0b 31 c0 48 83 c4 50 5b 41 5c 41 5d 41 5e 41 5f 5d c3 8b 4d c8
[ 136.701933] RSP: 0018:ffffa7c28284f980 EFLAGS: 00010246
[ 136.701936] RAX: 0000000000000000 RBX: ffff8e9304ac0000 RCX: 0000000000000000
[ 136.701937] RDX: 0000020100000000 RSI: ffffa7c28284f8b8 RDI: ffff8e930a628000
[ 136.701939] RBP: ffffa7c28284f9f8 R08: 0000000000000014 R09: ffff8e937ad00000
[ 136.701940] R10: 0000000000000031 R11: 0000000000000000 R12: 0000000000000001
[ 136.701941] R13: ffff8e934a160800 R14: 0000000000000000 R15: 0000000000000001
[ 136.701942] FS: 00007f546a3a4a40(0000) GS:ffff8e9a5da00000(0000) knlGS:0000000000000000
[ 136.701944] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 136.701945] CR2: 00007f70efb5f500 CR3: 00000001100f6000 CR4: 0000000000750ef0
[ 136.701947] PKRU: 55555554
[ 136.701948] Call Trace:
[ 136.701950] <TASK>
[ 136.701953] link_enc_cfg_link_encs_assign+0x1c9/0x3b0 [amdgpu]
[ 136.702129] dc_validate_global_state+0x57/0x330 [amdgpu]
[ 136.702310] ? drm_modeset_lock+0x8e/0xb0 [drm]
[ 136.702357] ? __raw_callee_save___native_queued_spin_unlock+0x15/0x23
[ 136.702366] amdgpu_dm_atomic_check+0x8e2/0xef0 [amdgpu]
[ 136.702558] ? __slab_alloc+0x20/0x40
[ 136.702562] ? __kmalloc_track_caller+0x1aa/0x490
[ 136.702565] ? amdgpu_dm_connector_atomic_duplicate_state+0x2a/0xd0 [amdgpu]
[ 136.702735] drm_atomic_check_only+0x5a5/0x8c0 [drm]
[ 136.702760] drm_atomic_commit+0x18/0x50 [drm]
[ 136.702779] drm_atomic_helper_set_config+0x7c/0xc0 [drm_kms_helper]
[ 136.702803] drm_mode_setcrtc+0x1fb/0x7b0 [drm]
[ 136.702846] ? drm_mode_getcrtc+0x190/0x190 [drm]
[ 136.702880] drm_ioctl_kernel+0xae/0xf0 [drm]
[ 136.702901] drm_ioctl+0x257/0x410 [drm]
[ 136.702939] ? drm_mode_getcrtc+0x190/0x190 [drm]
[ 136.702980] amdgpu_drm_ioctl+0x4e/0x80 [amdgpu]
[ 136.703135] __x64_sys_ioctl+0x91/0xc0
[ 136.703141] do_syscall_64+0x3b/0xc0
[ 136.703147] entry_SYSCALL_64_after_hwframe+0x44/0xae
[ 136.703152] RIP: 0033:0x7f546a70450b
[ 136.703154] Code: 0f 1e fa 48 8b 05 85 39 0d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 55 39 0d 00 f7 d8 64 89 01 48
[ 136.703156] RSP: 002b:00007fff039684f8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
[ 136.703159] RAX: ffffffffffffffda RBX: 00007fff03968530 RCX: 00007f546a70450b
[ 136.703160] RDX: 00007fff03968530 RSI: 00000000c06864a2 RDI: 000000000000000c
[ 136.703161] RBP: 00000000c06864a2 R08: 0000000000000000 R09: 000055d0e925e820
[ 136.703162] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
[ 136.703163] R13: 000000000000000c R14: 000055d0e8279c10 R15: 0000000000000000
[ 136.703166] </TASK>
[ 136.703167] ---[ end trace 5f977edd732e58fd ]---

This is fixed by the following commit which will be going into 5.18:
https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/amd/display/dc/core/dc_resource.c?id=6d33f0e820bfbc4f0b9b2f23d0d30df4bd6c3001

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1961746

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[You-Sheng Yang (vicamo)]

Correct: Impish 5.13 kernel is not affected by this issue as that assertion doesn't even exist.

[You-Sheng Yang (vicamo)]

Fixed in linux/jammy version 5.15.0-23.23, linux-oem-5.14/focal version 5.14.0-1033.36.