[MIR] plocate
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Release Notes for Ubuntu |
Fix Released
|
Undecided
|
Nick Rosbrook | ||
plocate (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Availability]
The package plocate is already in Ubuntu universe.
The package plocate builds for the architectures it is designed to work on.
It currently builds and works for architetcures: amd64, arm64, armhf, ppc64el, s390x
Link to package [[https:/
[Rationale]
- The package plocate will generally be useful for a large part of
our user base
- Package plocate covers the same use case as mlocate, but is better
because it is a faster implementation. From the package description:
"plocate is a locate(1) based on posting lists, giving much faster
searches on a much smaller index. It is a drop-in replacement for mlocate in
nearly all aspects, and is fast on SSDs and non-SSDs alike."
- Additional reasons: Debian has removed mlocate in favor of plocate.
[Security]
- No CVEs/security issues in this software in the past
http://
https:/
- /usr/bin/plocate binary is sgid
- There are binaries in sbin
/usr/
/usr/
- Package does install services, timers or recurring jobs
/lib/
/lib/
$ cat /lib/systemd/
[Unit]
Description
ConditionAC
[Service]
Type=oneshot
ExecStart=
LimitNOFILE
IOSchedulin
PrivateTmp=true
PrivateDevi
PrivateNetw
$ cat /lib/systemd/
[Unit]
Description
[Timer]
OnCalendar=
RandomizedD
AccuracySec
Persistent=true
[Install]
WantedBy=
- Packages does not open privileged ports (ports < 1024)
- Packages does not contain extensions to security-sensitive software
(filters, scanners, plugins, UI skins, ...)
[Quality assurance - function/usage]
- The package works well right after install. One must run
`updatedb` after install to do initial indexing, and can
then easily use `locate`.
[Quality assurance - maintenance]
- The package is maintained well in Debian/Ubuntu and has not too many
and long term critical bugs open
- Ubuntu https:/
- Debian https:/
- The package does not deal with exotic hardware we cannot support
[Quality assurance - testing]
- The package does not run a test at build time.
- The package runs an autopkgtest, and is currently passing on
amd64, arm64, armhf, ppc64el, s390x: https:/
- The package does have failing autopkgtests tests right now on i386,
but this package is not supported for i386
[Quality assurance - packaging]
- debian/watch is not present
- This package does not yield massive lintian Warnings, Errors
$ lintian --pedantic -I
I: plocate source: debian-
I: plocate source: out-of-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
I: plocate source: unused-
P: plocate source: spelling-
P: plocate source: trailing-whitespace debian/changelog (line 208)
P: plocate source: trailing-whitespace debian/changelog (line 226)
P: plocate source: trailing-whitespace debian/changelog (line 313)
P: plocate source: trailing-whitespace debian/changelog (line 320)
P: plocate source: trailing-whitespace debian/control (line 22)
- Lintian overrides are not present
- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies
- The package will not be installed by default
- Packaging and build is easy
[UI standards]
- Application is not end-user facing (does not need translation)
[Dependencies]
- No further depends or recommends dependencies that are not yet in main
[Standards compliance]
- This package correctly follows FHS and Debian Policy
[Maintenance/Owner]
- Upstream is active, the package is maintained in Debian and in sync for Ubuntu
- This does not use static builds
- This does not use vendored code
[Background information]
The Package description explains the package well
https:/
Changed in plocate (Ubuntu): | |
assignee: | nobody → Didier Roche (didrocks) |
tags: | added: fr-2074 |
description: | updated |
Changed in plocate (Ubuntu Jammy): | |
milestone: | ubuntu-22.04 → ubuntu-22.04-beta |
Changed in plocate (Ubuntu Jammy): | |
assignee: | Canonical Security Team (canonical-security) → Ubuntu Security Team (ubuntu-security) |
Changed in ubuntu-release-notes: | |
assignee: | nobody → Nick Rosbrook (enr0n) |
Changed in ubuntu-release-notes: | |
status: | New → Fix Released |
Review for Package: plocate
[Summary]
MIR team ACK, given the Required TODO is fixed, as it seems like a potential big issue to me.
Notes: 64-linux- gnu/. Those builds artefacts are included .exe and .o files. They are not present by default on the source package, but nothing prevents really to accidentally include them. I think it’s necessary to fix this and ensure we don’t embeed them in our source files, as those are arch-dependant, binary code results which would potentially override the one during the build due to a more recent timestamp.
Required TODOs:
- The source package can include binary content in obj-x86_
[Duplication]
This is a replacement of mlocate in main which provided the same functionality.
[Dependencies]
OK:
- no other Dependencies to MIR due to this
- checked with check-mir
- not listed in seeded-in-ubuntu
- none of the (potentially auto-generated) dependencies (Depends
and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
more tests now.
[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
- not a go package, no extra constraints to consider in that regard
[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
[Common blockers]
OK:
- does not FTBFS currently
- does have a non-trivial test suite that runs as autopkgtest
- no new python2 dependency
Problems:
- does not have a test suite that runs at build time. However, some autopkgtests are presents which covers then it.
[Packaging red flags]
OK:
- Ubuntu does carry a delta, but it is reasonable and maintenance under
control
- symbols tracking not applicable for this kind of code.
- d/watch is not present, but not needed
- Upstream update history is good (upstream is debian)
- Debian/Ubuntu update history is good
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list
Problems: 64-linux- gnu/. Those builds artefacts are included .exe and .o files. They are not present by default on the source package, but nothing prevents really to accidentally include them. I think it’s necessary to fix this and ensure we don’t embeed them in our source files, as those are arch-dependant, binary code results which would potentially override the one during the build due to a more recent timestamp.
- The source package can include binary content in obj-x86_
[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or...