Mahara

Courseinfo blocktype plugin modal is blank

Bug #1959860 reported by Dianne Tennent
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 22.04.0
21.10
Fix Released
High
Unassigned
Mahara 21.10.2
22.04
Fix Released
High
Robert Lyon
Mahara 22.04.0

Bug Description

On main branch.

Go to Admin/Extensions/Plugin Administration
Click the 'Info' icon next to the 'Courseinfo' blocktype plugin setting

Expected:
Modal appears with information

Actual:
Blank modal appears

This seems to be a regression of this patch here: https://bugs.launchpad.net/mahara/+bug/1903618

See original description
Tags: regression
Dianne Tennent (dianne-t)
description: updated
Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 22.04.0
tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12479

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12479
Committed: https://git.mahara.org/mahara/mahara/commit/47f03585252a9e7ffcd6b0882c3469df2da8c68c
Submitter: Doris Tam (<email address hidden>)
Branch: main

commit 47f03585252a9e7ffcd6b0882c3469df2da8c68c
Author: Robert Lyon <email address hidden>
Date: Mon Mar 7 14:57:01 2022 +1300

Bug 1959860: Plugin info link needs to work as button also

Before we were checking only for a <A> parent but now
we check for either an <A> or <Button> parent that has the data
attribute we need.

This patch makes it possible to click the 'Info' button at
Admin menu -> Extensions -> Plugin administration -> courseinfo
and have the modal appear with the additional information.

Change-Id: I3a94c21d84933662f67f7e35a2a1887e845693d9
Signed-off-by: Robert Lyon <email address hidden>

Kristina Hoeppner (kris-hoeppner)
Changed in mahara:
status: In Progress → Fix Committed
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara/21.04
no longer affects: mahara/20.10
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12509

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12509
Committed: https://git.mahara.org/mahara/mahara/commit/85f411c166667f88a14ec67af7a6a1c665f106a0
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit 85f411c166667f88a14ec67af7a6a1c665f106a0
Author: Robert Lyon <email address hidden>
Date: Mon Mar 7 14:57:01 2022 +1300

Bug 1959860: Plugin info link needs to work as button also

Before we were checking only for a <A> parent but now
we check for either an <A> or <Button> parent that has the data
attribute we need.

This patch makes it possible to click the 'Info' button at
Admin menu -> Extensions -> Plugin administration -> courseinfo
and have the modal appear with the additional information.

Change-Id: I3a94c21d84933662f67f7e35a2a1887e845693d9
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 47f03585252a9e7ffcd6b0882c3469df2da8c68c)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.