CentOS9: puppet apply fails because /etc/sysconfig/libvirtd is no longer provided by packages

[Dariusz Smigiel]

Issue found during test run of TripleO CI [1]

~~~
2022-01-31T01:48:00.342769355+00:00 stderr F <13>Jan 31 01:48:00 puppet-user: Error: /Stage[main]/Nova::Migration::Libvirt/File_line[/etc/sysconfig/libvirtd libvirtd args]: Could not evaluate: No such file or directory @ rb_sysopen - /etc/sysconfig/libvirtd
...

2022-01-31T01:48:02.802464279+00:00 stderr F <13>Jan 31 01:48:02 puppet-user: Notice: /Stage[main]/Nova::Logging/File[/var/log/nova/nova-manage.log]: Dependency File_line[/etc/sysconfig/libvirtd libvirtd args] has failures: true
...
~~~

[1]: https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-9-standalone-on-multinode-ipa-master/8a1456e/logs/undercloud/var/log/containers/stdouts/container-puppet-nova_libvirt.log.txt.gz

libvirt stopped providing /etc/sysconfig files since 8.1 (though we see this change in 8.0 packages in CentOS9 Stream)

The same failure can be found in recent centos9 integration jobs.

https://zuul.opendev.org/t/openstack/build/1b973a49225941e3b3d67ecd0e0638bf

https://5c41d2dd121f76bb884b-c3c5403b50cc5c472b5c2a0df6c04f3a.ssl.cf1.rackcdn.com/826952/2/check/puppet-openstack-integration-7-scenario001-tempest-centos-9-stream/1b973a4/logs/puppet.txt
~~~
2022-01-31 10:01:04 +0000 /Stage[main]/Nova::Migration::Libvirt/File_line[/etc/sysconfig/libvirtd libvirtd args] (err): Could not evaluate: No such file or directory @ rb_sysopen - /etc/sysconfig/libvirtd
/etc/puppet/modules/stdlib/lib/puppet/provider/file_line/ruby.rb:82:in `readlines'
/etc/puppet/modules/stdlib/lib/puppet/provider/file_line/ruby.rb:82:in `lines'
/etc/puppet/modules/stdlib/lib/puppet/provider/file_line/ruby.rb:16:in `exists?'
...
~~~

[Douglas Viroel (dviroel)]

Proposed fixes:
https://review.opendev.org/q/topic:bug%252F1959601

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-nova/+/826889
Committed: https://opendev.org/openstack/puppet-nova/commit/99830f8a2d5f3f2b56ed4c050b36fd363c8911e6
Submitter: "Zuul (22348)"
Branch: master

commit 99830f8a2d5f3f2b56ed4c050b36fd363c8911e6
Author: Alfredo Moralejo <email address hidden>
Date: Fri Jan 28 14:05:32 2022 +0100

    CentOS: Ensure /etc/sysconfig/libvirtd(-guests) exists

    Last build of libvirt in CentOS9 has removed default config files in
    /etc/sysconfig . This is making some file_line resources to fail as
    the original files no longer exist.

    This patch is creating empty files if the target files don't exist, so
    that this is compatible with centos8 and centos9 (before and after
    default config files removal).

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2042529

    Closes-Bug: #1959601
    Change-Id: Iff9daf3d284c725d40ecfb85500d77951c3fefcd

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-nova/+/827407

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-nova/+/827631

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-nova/+/827407
Committed: https://opendev.org/openstack/puppet-nova/commit/b9398853358be5cb2075cdbb18eff8fd9e22b2dd
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b9398853358be5cb2075cdbb18eff8fd9e22b2dd
Author: Alfredo Moralejo <email address hidden>
Date: Fri Jan 28 14:05:32 2022 +0100

    CentOS: Ensure /etc/sysconfig/libvirtd(-guests) exists

    Last build of libvirt in CentOS9 has removed default config files in
    /etc/sysconfig . This is making some file_line resources to fail as
    the original files no longer exist.

    This patch is creating empty files if the target files don't exist, so
    that this is compatible with centos8 and centos9 (before and after
    default config files removal).

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2042529

    Closes-Bug: #1959601
    Change-Id: Iff9daf3d284c725d40ecfb85500d77951c3fefcd
    (cherry picked from commit 99830f8a2d5f3f2b56ed4c050b36fd363c8911e6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-nova/+/827631
Committed: https://opendev.org/openstack/puppet-nova/commit/5c8d68ab5e207ec1784ce4c1a9d29f778d4cfaf8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5c8d68ab5e207ec1784ce4c1a9d29f778d4cfaf8
Author: Alfredo Moralejo <email address hidden>
Date: Fri Jan 28 14:05:32 2022 +0100

    CentOS: Ensure /etc/sysconfig/libvirtd(-guests) exists

    Last build of libvirt in CentOS9 has removed default config files in
    /etc/sysconfig . This is making some file_line resources to fail as
    the original files no longer exist.

    This patch is creating empty files if the target files don't exist, so
    that this is compatible with centos8 and centos9 (before and after
    default config files removal).

    [1] https://bugzilla.redhat.com/show_bug.cgi?id=2042529

    Closes-Bug: #1959601
    Change-Id: Iff9daf3d284c725d40ecfb85500d77951c3fefcd
    (cherry picked from commit 99830f8a2d5f3f2b56ed4c050b36fd363c8911e6)
    (cherry picked from commit b9398853358be5cb2075cdbb18eff8fd9e22b2dd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 18.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 20.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 19.5.0 release.