Cannot filter share server by share-network-subnet

[Felipe Rodrigues]

INTRO
====================================
The share server list operation has the possibility to request share servers that is on specific share network subnet using the field "--share-network-subnet". However, the list is not returning any servers.

REPRODUCE:
=========================

1. Create share in subnet <id>
2. List share server in subnets <id>
3. No share servers.

See: [1]

PROBLEM
========================

The code is setting the query field as "share_network_subnet" [2], but the manila API expects the field as "share_network_subnet_id".

Apparently, there is no tempest test to check the share server subnet filter. It'd be nice to have at least one.

VERSION
========================
python-manilaclient: latest
manila: latest

REFERENCE
================================
[1] https://paste.opendev.org/show/812410/
[2] https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L4311

[Goutham Pacha Ravi (gouthamr)]

Adding manila here to highlight Felipe's request for a tempest test -- this test must be added in manila-tempest-plugin, but there's no separate launchpad tracker page for that repository.

[Franca Mgbogu (franciedigital)]

Okay. I will create a tempest test for this.

[Goutham Pacha Ravi (gouthamr)]

Fix proposed to branch: master (python-manilaclient)
https://review.opendev.org/c/openstack/python-manilaclient/+/838293

[Vida Haririan (vhariria)]

See additional discussions at https://meetings.opendev.org/meetings/manila/2022/manila.2022-04-21-15.00.log.html

[Franca Mgbogu (franciedigital)]

Noted! Thanks

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-manilaclient/+/838293
Committed: https://opendev.org/openstack/python-manilaclient/commit/27b8830309c186c12f6b87c7d9a045325ea03e16
Submitter: "Zuul (22348)"
Branch: master

commit 27b8830309c186c12f6b87c7d9a045325ea03e16
Author: Franca Mgbogu <email address hidden>
Date: Mon Apr 18 12:43:49 2022 +0100

    Fix share server listing with network subnet id

    Share server list operation is supposed to accept share
    network subnet ids as parameters for filtering share servers.
    The share specified share network subnet ids were being
    ignored. This change fixes this behavior by allowing that
    search to occur properly.

    Closes-Bug: #1959329

    Change-Id: I6453e9d20a0b4ace0d71c501c5a65c6736554f0d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-manilaclient 4.1.0 release.

[Goutham Pacha Ravi (gouthamr)]

Adding the "low-hanging-fruit" tag because the only thing remaining here is to create a tempest test to test the filtering change done..